On 1/6/06, mista <[EMAIL PROTECTED]> wrote: > for now efm's mimesystem looks like a lot strcmp(strrchr()). can we add > an element > char *mime in E_Fm_File and a function to check if E_Fm_Assoc_App > matches with a file? >
We can add the mime info to the E_Fm_File struct for easier and faster access. > > I can only do this if icon_pack returns something from which i can get > the coordinates where on the canvas th icon is located. Currently I let > it return just the coordinates. > I'm sure we can do something about this, do what you need for now and I'll have a look at it. > I thought it would be good to have the mimetypes stored in the eap, > because every application that shows/uses this eap has directly access > to the mime information. That would make it for example possible that > ibar or engage know when a file is dropped on an eap if the file can be > opened with it. If an Application like efm creates a new mime to > application assignment and stores them in an eaps, then this > information can be reused by other apps very simple. > This is an idea, but I do not think it is the way to go. Eaps do not gaurantee that they can open a certain type or even work with files. They are just a way to attach an icon to something that can run (script, app etc...) Since both ibar and engage are modules, if we build this into E (a mime lookup system) then anything using E can make use of it. > As far as I know e17genmenu should become the standard app to create > eap-sets. The data it uses to create eaps comes from desktop-files, > which include often a list of mimetypes. My point, is that we should use > that list and not write every mimetype for every app by hand. > We also can not gaurantee this as being available. > For now i changed my own ugly eap generator to store this list in the > comments field of the eap. when efm starts it go through the global eap > list and generates a list to lookup an application by mimetype. then, > when an icon-menu gets opened it goes through the list to lookup > suitable applications, which then get shown in a submenu. > > is this what you asked for? > Same logic for the menu stuff, except we get the mimes from our mime->app list. > I don´t know how to make patches against a cvs-tree. Can you give me a list > of commands you are using? once you have the code added and working, just do: cvs diff > foo.patch from you e dir. > Have you rules for identation? Basically just follow the coding style, if you use vim then the header in the files will help. > When I apply my local patch the identation looks completly messed up. Should > I then > make two patches, one to delete the old part and a second to fill in the new? > the attached patch are the corrected key select functions, > more to follow when i know how its done right (my diff dont allow the -3 > option???) > I am not sure about this. Best Regards, hisham -- Hisham Mardam Bey MSc (Computer Science) http://hisham.cc/ +9613609386 Codito Ergo Sum (I Code Therefore I Am) ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_idv37&alloc_id865&op=click _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
