Jorge Luis Zapata Muga wrote:
On 1/7/06, Morten Nilsen <[EMAIL PROTECTED]> wrote:
+++ e/src/bin/e_menu.c 2006-01-07 11:43:25.054986869 +0100
+void *
+e_menu_category_callback_add(char *category, void (*create) (E_Menu *m, void
*category_data, void *data), void (*free) (void *data), void *data)
+{
+}
+
+void
+e_menu_category_callback_del(char *category, void *handle)
+{
+}
+++ e/src/bin/e_menu.h 2006-01-07 11:44:47.939910840 +0100
+EAPI void e_menu_category_callback_add(char *category, void (*create)
(E_Menu *m, void *category_data, void *data), void (free) (void *data), void
*data);
+EAPI void *e_menu_category_callback_del(char *category, void *handle);
Your efm is kind of old, also you shouldnt make changes to it because
the problem is on the "client" api (_callback_set) on the e_menu.c
I stated my efm was kind of old, yes.. I only tried being helpful by
making the mentioned adjustments to the patch...
.. on a different note, it would be nice if you in the future snip
quoted text.. had to scroll a few miles to get to your reply ;)
and also, when making patches, make them unified (diff -u) please :)
On _callback_del you expect a handle to be passed, by the code i
suspect it is a E_Menu_Category_Callback struct, but the client doesnt
have this struct, it is only internal to the e_menu.c so it must
receive again the callback for create and the callback for free as in
the _callback_set, iterate through the list and compare the pointers,
if its found delete it from the list. Also the definition is wrong
compared to the prototype of the function.
only by a misplaced *.. not a difficult thing to resolve :)
I only added a _del function and renamed _set to _add after applying
your patch to my tree..
--
Morten
:wq
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
