2017-10-27 16:15 GMT+09:00 Amitesh Singh <[email protected]>: > On Fri, Oct 27, 2017 at 3:55 PM, Amitesh Singh <[email protected]> > wrote: > > > > > > > On Wed, Oct 25, 2017 at 9:36 PM, Marcel Hollerbach < > [email protected] > > > wrote: > > > >> bu5hm4n pushed a commit to branch master. > >> > >> http://git.enlightenment.org/core/efl.git/commit/?id=f440cc4 > >> eb6edbda0a0093df785ab1bc02ee21835 > >> > >> commit f440cc4eb6edbda0a0093df785ab1bc02ee21835 > >> Author: Marcel Hollerbach <[email protected]> > >> Date: Wed Oct 25 13:57:32 2017 +0200 > >> > >> elm_multibuttonentry: do not eat all the events > >> > >> I have no idea why it was doing that, but that ends up eating all > the > >> events, not propagating them up to the parent ... If someone has a > >> idea > >> why it was like that, feel free to notify. > >> --- > >> src/lib/elementary/efl_ui_multibuttonentry.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/src/lib/elementary/efl_ui_multibuttonentry.c > >> b/src/lib/elementary/efl_ui_multibuttonentry.c > >> index 0456532b63..b1abc2d00d 100644 > >> --- a/src/lib/elementary/efl_ui_multibuttonentry.c > >> +++ b/src/lib/elementary/efl_ui_multibuttonentry.c > >> @@ -984,7 +984,8 @@ _efl_ui_multibuttonentry_elm_widget_widget_event(Eo > >> *obj EINA_UNUSED, Efl_Ui_Mul > >> // ACCESS > >> if (_elm_config->access_mode == ELM_ACCESS_MODE_ON) return > EINA_FALSE; > >> > >> - return EINA_TRUE; > >> + //lets stop eating all events > >> + return EINA_FALSE; > >> } > >> > >> EOLIAN static void > >> > >> -- > >> > > > > f440cc4eb6edbda0a0093df785ab1bc02ee21835 and > > 53fcc4bb7de3bfc9c69f6e138bc25a1f52a49744 breaks the shrink feature in > MBE. > > Please verify it with elm test -> multibuttonentry shrink example. > > > > > Okay, so 53fcc4bb7de3bfc9c69f6e138bc25a made mbe a not focusable widget by > default and the elm test case rely on focus property of mbe. > so fixed it by making mbe focusable. >
Surely there was a very good reason for Marcel to make it unfocusable. You patch b6567ab1f6fa377f4047106bae8aa808ff033180 changes the test case. Please revert it. -- Jean-Philippe André ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
