> - if (buf)
> + if (sd->format_cb)
> {
> - elm_layout_text_set(sd->obj, "month_text", buf);
> - free(buf);
> + Eina_Value val;
> + const char *buf;
> +
> + eina_value_setup(&val, EINA_VALUE_TYPE_TM);
broken indentation.
> EOLIAN static void
> -_efl_ui_calendar_format_function_set(Eo *obj EINA_UNUSED,
> Efl_Ui_Calendar_Data *sd, Efl_Ui_Calendar_Format_Cb format_function)
> +_efl_ui_calendar_efl_ui_format_format_cb_set(Eo *obj, Efl_Ui_Calendar_Data
> *sd, void *func_data, Efl_Ui_Format_Func_Cb func, Eina_Free_Cb func_free_cb)
> {
IMO it would be better to add timeval and tm support to the generic
format function provided by efl_ui_format... it already handles
double/integer... should handle date and all variations of basic
types, then there is no need to provide those in calendar... then on
other widgets that may need time and date format, you'd just pass the
string. Say you create a "date input field", it would need to format
similarly to calendar.
--
Gustavo Sverzut Barbieri
--------------------------------------
Mobile: +55 (16) 99354-9890
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
