On Mon, 13 Nov 2017 11:37:43 +0900 Jean-Philippe André <j...@videolan.org> wrote:
Yo, > Hi, > > 2017-11-13 3:12 GMT+09:00 Daniel Zaoui <jackdani...@eyomi.org>: > > > Hi guys, > > > > I have some issue concerning the parsing of the installed Eo files. > > It is now impossible to parse some of them because of the > > dependency on internal Eo files/types. > > > > A simple case is efl_ui_calendar.eo that fails during Eolian parsing > > because it references Elm.Calendar.Weekday in the comments. We have > > another case where efl_ui_text.eo imports elm_entry that is > > internal, leading to a parsing error. I am sure there are/will be > > other cases. > > Calendar is a small issue, entry is a larger problem, as I see > Efl.Ui.Text still has quite a few APIs that aren't really "eo-ready" > yet (item providers, cnp, context menu in particular). > > > > So now, I try to understand which solution we have: > > - Don't install Eo files at all: shitty. > > - Fix the failing Eo files so they dont depend on internals. > > > > Solution 2 is the only correct way here. > As far as I'm concerned, if make distcheck passes and I can build > external apps (E, terminology) there isn't much more I can do to > verify install is fine. The problem with distcheck is that almost no one runs it. So checking there will not help people to fix stuff before pushing. > > Maybe we should check the Eo files validity during installation, by > running > > eolian_gen on the files to install. Is it do-able? > > > > It would be fine for me if there was a tool to run on the installed > files. After installation is fine. > Maybe run the documentation generator? I think eolian_gen can do the job. We just need some option to just validate some Eo file. No generation. > > Anyhow I'm sorry that I broke everything for you with that change. As > we discussed earlier, this had to be done, and I think now is a good > time to try and fix everything. Having errors is a good way to know > what to fix :) If you have any specific issue or a tool I can run, > let me know so I can help! You know I will never excuse you for that!!! Seriously, I know why you did that and I fully understand. The best tool seems eolian_gen that is run on the installed Eo files, as it is already inside EFL and needs one more simple option. We only should need to run it after the installation. > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
