The wording is intentional. The meson build has a tendency to touch build files during the install phase (which must be run as root to install to the base system), meaning that failure to use sudo during general build will fail for subsequent builds anyway due to permissions errors when attempting to modify root-owned files.
On Mon, Nov 20, 2017 at 8:14 PM Carsten Haitzler <ras...@rasterman.com> wrote: > On Mon, 20 Nov 2017 15:04:48 +0000 Mike Blumenkrantz > <michael.blumenkra...@gmail.com> said: > > > Issues had been found at an inconvenient time during review, so I left > the > > branch unmerged so that someone could either push while I was gone or I > > could push when I returned. > > I saw you pushed now. so we know the status. This also clears up the build > system state. I guess I should ensure it's documented. I see README > changed but > i am not sure it's correct as it's going to do a build as root... i'll deal > with it. :) > > > On Sun, Nov 19, 2017 at 6:56 PM Carsten Haitzler <ras...@rasterman.com> > > wrote: > > > > > On Sun, 19 Nov 2017 13:05:06 +0000 Andrew Williams < > a...@andywilliams.me> > > > said: > > > > > > > Hi, > > > > > > > > As the autotool/Makefiles are still in place I fixed the build for > users > > > > not yet using the E meson build. > > > > > > i was assuming autotools was dead - mike did say he'd push his > autotools > > > removal branch "in a day or 2 if no issues"... that about 1-2 weeks > back. i > > > didn't see it happen and didn't hear of issues... > > > > > > are there any? I'd consider merging his branch to remove autofoo at > this > > > point. > > > If meson has issues it should be tested and they should be fixed. > > > > > > > Andy > > > > > > > > On Fri, 17 Nov 2017 at 03:19 Carsten Haitzler <ras...@rasterman.com> > > > wrote: > > > > > > > > > raster pushed a commit to branch master. > > > > > > > > > > > > > > > > > > > http://git.enlightenment.org/core/enlightenment.git/commit/?id=f4d2d02ba0f15b7f36e7de61141ff88c145f5630 > > > > > > > > > > commit f4d2d02ba0f15b7f36e7de61141ff88c145f5630 > > > > > Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com> > > > > > Date: Fri Nov 17 12:17:42 2017 +0900 > > > > > > > > > > music-control - install properly with meson build with icon > > > > > > > > > > @fix > > > > > --- > > > > > ...-module-music_control.edj => e-module-music-control.edj} | Bin > > > > > src/modules/music-control/meson.build | 2 > -- > > > > > src/modules/music-control/module.desktop | 2 > +- > > > > > 3 files changed, 1 insertion(+), 3 deletions(-) > > > > > > > > > > diff --git a/src/modules/music-control/e-module-music_control.edj > > > > > b/src/modules/music-control/e-module-music-control.edj > > > > > similarity index 100% > > > > > rename from src/modules/music-control/e-module-music_control.edj > > > > > rename to src/modules/music-control/e-module-music-control.edj > > > > > diff --git a/src/modules/music-control/meson.build > > > > > b/src/modules/music-control/meson.build > > > > > index 996b4196f..a84f5ea8e 100644 > > > > > --- a/src/modules/music-control/meson.build > > > > > +++ b/src/modules/music-control/meson.build > > > > > @@ -18,5 +18,3 @@ src += custom_target('gen-dbus', > > > > > command: [eldbus_codegen, '@INPUT@', '-O', > > > '@OUTDIR@ > > > > > '], > > > > > output : created_file > > > > > ) > > > > > - > > > > > -no_icon = true > > > > > diff --git a/src/modules/music-control/module.desktop > > > > > b/src/modules/music-control/module.desktop > > > > > index 99a2d9143..2e12677e3 100644 > > > > > --- a/src/modules/music-control/module.desktop > > > > > +++ b/src/modules/music-control/module.desktop > > > > > @@ -27,5 +27,5 @@ Comment[nl]=Beheers uw muziek op uw plank > > > > > Comment[ru]=Модуль для управления воспроизведением музыки > > > > > Comment[sr]=Управљајте музиком са полице > > > > > Comment[tr]=Müziğinizi rafta kontrol edin > > > > > -Icon=e-module-music_control > > > > > +Icon=e-module-music-control > > > > > X-Enlightenment-ModuleType=utils > > > > > > > > > > -- > > > > > > > > > > > > > > > -- > > > > http://andywilliams.me > > > > http://ajwillia.ms > > > > > > > > ------------------------------------------------------------------------------ > > > > Check out the vibrant tech community on one of the world's most > > > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > > _______________________________________________ > > > > enlightenment-devel mailing list > > > > enlightenment-devel@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > -- > > > ------------- Codito, ergo sum - "I code, therefore I am" > -------------- > > > Carsten Haitzler - ras...@rasterman.com > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > Check out the vibrant tech community on one of the world's most > > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > _______________________________________________ > > > enlightenment-devel mailing list > > > enlightenment-devel@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > ------------------------------------------------------------------------------ > > Check out the vibrant tech community on one of the world's most > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > Carsten Haitzler - ras...@rasterman.com > > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
