On Mon, Nov 27, 2017 at 4:49 AM, Jean-Philippe André <[email protected]> wrote: > On Sun, Nov 26, 2017 at 9:25 PM, Gustavo Sverzut Barbieri < > [email protected]> wrote: > >> On Thu, Nov 23, 2017 at 9:58 PM, Pawel Aksiutowicz >> <[email protected]> wrote: >> > ecore_con: quiet 2 "clobbered" warnings in ecore_con >> ... >> > - uint8_t user_len = user ? strlen(user) : 0; >> > - uint8_t pass_len = pass ? strlen(pass) : 0; >> > + volatile uint8_t user_len = user ? strlen(user) : 0; >> > + volatile uint8_t pass_len = pass ? strlen(pass) : 0; >> >> what? someone care to explain why adding "volatile" here quites >> clobbered... what was clobbered? it makes no sense to me to add these >> volatile :-S >> >> > When compiling with GCC -Ofast with we get this kind of errors: > > /home/jpeg/e/core/optimized-efl/src/lib/ecore_con/ecore_con.c: In function > ‘_efl_net_ip_connect_async_run_socks4a’: > /home/jpeg/e/core/optimized-efl/src/lib/ecore_con/ecore_con.c:1247:16: > warning: variable ‘proxy_user’ might be clobbered by ‘longjmp’ or ‘vfork’ > [-Wclobbered] > const char *proxy_user, *proxy_pass, *proxy_host, *proxy_port; > ^~~~~~~~~~ > > I know that volatile prevents this kind of warning. That's all I know > though, I don't quite understand the exact meaning of the warning nor do I > find longjmp or vfork in that code.
maybe it's related to cancellable code, these guys run in a thread that is cancellable... but still, message and location seems weird. fix seems even more weird to me -- Gustavo Sverzut Barbieri -------------------------------------- Mobile: +55 (16) 99354-9890 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
