Hi Andy,

On Tue, Nov 28, 2017 at 6:23 AM, Andy Williams <a...@andywilliams.me> wrote:

> ajwillia-ms pushed a commit to branch master.
>
> http://git.enlightenment.org/core/efl.git/commit/?id=
> d43fe6c16fd763215e2741b37baa8df913f151c0
>
> commit d43fe6c16fd763215e2741b37baa8df913f151c0
> Author: Andy Williams <a...@andywilliams.me>
> Date:   Mon Nov 27 21:23:11 2017 +0000
>
>     elm_code: Reload grid colours on theme change
> ---
>  src/lib/elementary/elm_code_widget.c  | 34 +++++++++++++++++++++++++++---
> ----
>  src/lib/elementary/elm_code_widget.eo |  1 +
>  2 files changed, 28 insertions(+), 7 deletions(-)
>
> diff --git a/src/lib/elementary/elm_code_widget.c
> b/src/lib/elementary/elm_code_widget.c
> index e61aa6afea..774e763c78 100644
> --- a/src/lib/elementary/elm_code_widget.c
> +++ b/src/lib/elementary/elm_code_widget.c
> @@ -1874,7 +1874,7 @@ _elm_code_widget_ensure_n_grid_rows(Elm_Code_Widget
> *widget, int rows)
>          evas_object_size_hint_weight_set(grid, EVAS_HINT_EXPAND, 0.0);
>          evas_object_size_hint_align_set(grid, EVAS_HINT_FILL, 0.0);
>          evas_object_show(grid);
> -        _elm_code_widget_setup_palette(grid,
> efl_parent_get(pd->scroller));
> +        _elm_code_widget_setup_palette(grid, widget);
>
>          elm_box_pack_end(pd->gridbox, grid);
>          pd->grids = eina_list_append(pd->grids, grid);
> @@ -2192,13 +2192,35 @@ _elm_code_widget_cursor_position_get(Eo *obj
> EINA_UNUSED, Elm_Code_Widget_Data *
>     *col = pd->cursor_col;
>  }
>
> +EOLIAN static Efl_Ui_Theme_Apply
> +_elm_code_widget_elm_widget_theme_apply(Eo *obj, Elm_Code_Widget_Data
> *pd)
> +{
> +   Eo *edje;
> +   int r, g, b, a;
> +   unsigned int i;
> +   Evas_Object *grid, *background;
> +
> +   edje = elm_layout_edje_get(obj);
> +   edje_object_color_class_get(edje, "elm/code/status/default", &r, &g,
> &b, &a,
> +                               NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> NULL);
> +
> +   background = elm_object_part_content_get(pd->scroller,
> "elm.swallow.background");
> +   evas_object_color_set(background, r, g, b, a);
> +
> +   for (i = 0; i < eina_list_count(pd->grids); i++)
> +     {
> +        grid = eina_list_nth(pd->grids, i);
> +        _elm_code_widget_setup_palette(grid, obj);
> +     }
> +
> +   return EFL_UI_THEME_APPLY_SUCCESS;
> +}
>

I don't see any call to efl_super() so I wonder how the new edje is
supposed to be loaded?
You may want to refer to _efl_ui_button_elm_widget_theme_apply() for
instance.

Best regards,
--
JP
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to