Hello,

yes this needs to be after the call to

efl_ui_focus_composition_elements_set,

Plan is to limit it to the items that are visible. (Thats what i am working on right now...)

However i might revert it, since it created some wierd genlist issue that i cannot fix right now.

Greetings,
   bu5hm4n


On 01/24/2018 08:06 PM, michael bouchaud wrote:
Hum, this can't be done into another for-each loop already here ? Because
iterate items into a genlist gengrid one more time, could be a drawback.

Le 23 janv. 2018 21:28, "Marcel Hollerbach" <mar...@osg.samsung.com> a
écrit :

bu5hm4n pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=
b2be688ccc570d74517b9217ac28135f80953f29

commit b2be688ccc570d74517b9217ac28135f80953f29
Author: Marcel Hollerbach <mar...@osg.samsung.com>
Date:   Tue Jan 23 20:58:59 2018 +0100

     elm_genlist: prepare the item when its set

     so the border element is set accordingly on the parent manager which
     then can be picked up for focus relations.

     ref T6453
---
  src/lib/elementary/elm_genlist.c | 9 +++++++++
  1 file changed, 9 insertions(+)

diff --git a/src/lib/elementary/elm_genlist.c b/src/lib/elementary/elm_
genlist.c
index 4aaba095eb..dcaff43bfe 100644
--- a/src/lib/elementary/elm_genlist.c
+++ b/src/lib/elementary/elm_genlist.c
@@ -8772,6 +8772,15 @@ _elm_genlist_efl_ui_focus_composition_prepare(Eo
*obj, Elm_Genlist_Data *pd)
       }

     efl_ui_focus_composition_elements_set(obj, order);
+
+   EINA_INLIST_FOREACH(pd->items, item)
+     {
+        if (item->base->disabled)
+          continue;
+
+        efl_ui_focus_object_prepare_logical(item->base->eo_obj);
+     }
+
  }

  EOLIAN static void

--



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to