On Sat, 24 Feb 2018 23:35:13 +0900 Carsten Haitzler (The Rasterman) <[email protected]> wrote:
> I think this ticket says it pretty much: > > https://phab.enlightenment.org/T6726 > > If you are interested, please help out. Details there in the ticket. One thing I ran into that I believe will be an issue for this new theme as well. There are some, not to many, applications that have their own edj files. Some of those are re-using elements from the current default theme. When you change your theme for E/EFL, that stuff does not fully change. It looks off, and they have to have their own alternative themes, and edj files for each system theme. Like Flat for other apps. It was tricky for me in Entrance to re-use the default E desktop background. I got lucky it was a group I could re-use. Few things can be re-used like that it seems. https://github.com/Obsidian-StudiosInc/entrance/blob/master/src/bin/entrance_gui.c#L635 I ran into this with etui and opened an issue I have not had a chance to play with a fix for yet. https://github.com/vtorri/etui/issues/27 That same thing is also an issue for Verne and Terminology. For my theme eminence, I modify Terminology's default edj file and ship a edj edj for Terminology to match my theme. I rather not have to make one for etui, ephoto, etc. When I change themes for E, I still have to go change the theme for Terminology. Not really ideal, and if more apps... https://github.com/Obsidian-StudiosInc/eminence/releases You can see the issues in the following screenshot. In my theme and for Terminology I removed the glow and blue inner shadow is purple. But in this screenshot for etui it still has default theme looks with glow and blue inner shadow. Which is why I opened that issue for etui. https://www.enlightenment.org/ss/e-5a91e83c4e3b53.65255985.jpg In that same screenshot Verne has Blue arrows like the default arrows. Because I assume it could not access the default elementary arrow images or any group. Thus they were copied and in the Verne edj file. https://github.com/marcelhollerbach/verne/blob/master/data/img/icon_arrow_left.png https://github.com/marcelhollerbach/verne/blob/master/data/img/icon_arrow_right.png Do those arrows look familiar? Same as here but could not be re-used https://github.com/Enlightenment/efl/blob/master/data/elementary/themes/img/icon_arrow_left.png https://github.com/Enlightenment/efl/blob/master/data/elementary/themes/img/icon_arrow_right.png Same for etui, all these images are duplicated from default theme https://github.com/vtorri/etui/tree/master/data/themes/images Also Terminology https://git.enlightenment.org/apps/terminology.git/tree/data/themes/images Same icons duplicated in a few edj files, not really ideal. None of that stuff changes with the default system theme. Its a pro and con. Its good for applications to be able to have their own theme. Bad when it is matching the default theme, and has to copy over elements. Which makes it not able to benefit from system theme changes. IMHO its a pretty big issue for theming all around. With having new themes for E. Those applications have to update If E offers dark/light. Those applications need to as well. Plus the user still has to change E theme and Application themes like Terminology independently. -- William L. Thomson Jr.
pgpk7s6PV1QQ_.pgp
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
