On Sun, 11 Mar 2018 16:51:47 -0300 Gustavo Sverzut Barbieri <barbi...@gmail.com> said:
> On Sat, Mar 10, 2018 at 8:04 AM, Carsten Haitzler <ras...@rasterman.com> > wrote: > > raster pushed a commit to branch master. > > > > http://git.enlightenment.org/core/efl.git/commit/?id=965f257e70b2766b41df57c6ead59d422b632062 > > > > commit 965f257e70b2766b41df57c6ead59d422b632062 > > Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com> > > Date: Sat Mar 10 20:02:09 2018 +0900 > > > > ecore - efl exe/thread - only allow run once ever > > --- > > src/lib/ecore/efl_exe.c | 5 ++++- > > src/lib/ecore/efl_thread.c | 3 +++ > > 2 files changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/src/lib/ecore/efl_exe.c b/src/lib/ecore/efl_exe.c > > index 4ef0aee967..273b97532e 100644 > > --- a/src/lib/ecore/efl_exe.c > > +++ b/src/lib/ecore/efl_exe.c > > @@ -61,6 +61,7 @@ struct _Efl_Exe_Data > > } fd; > > #endif > > Eina_Bool exit_called : 1; > > + Eina_Bool run : 1; > > }; > > if you used pd->promise here, there is no need to keep that flag. it doesn't exist. there is no promise in the object. so i added a flag for now. > I'm not sure why you're trying to co-exist promise with-no-promise for > this API, this will just add confusion and code to maintain. Here > you're adding one more method, one more event, etc... :-( i'm not having them co-exist. there is no promise in the api. it only uses an event. i gave up on that. that was the start of that promises thread. using an event was a lot less code than using a promise. go back to the start of that mail thread. :) -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- Carsten Haitzler - ras...@rasterman.com ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
