On March 28, 2018 8:00 PM, Carsten Haitzler <ras...@rasterman.com> wrote: > On Wed, 28 Mar 2018 12:21:53 -0400 Cedric Bail ced...@ddlm.me said: > > On March 27, 2018 10:18 PM, Carsten Haitzler ras...@rasterman.com wrote: > > > On Fri, 23 Mar 2018 22:57:28 +0900 Stefan Schmidt ste...@osg.samsung.com > > > said: > > > > > > > On 03/21/2018 09:57 AM, Cedric BAIL wrote: > > > > > cedric pushed a commit to branch master. > > > > > > > > > > http://git.enlightenment.org/core/efl.git/commit/?id=4c4177ac207f982de8139c47c7afedd26ff9e15a > > > > > > > > > > commit 4c4177ac207f982de8139c47c7afedd26ff9e15a > > > > > Author: Cedric BAIL ced...@osg.samsung.com > > > > > Date: Thu Mar 15 12:50:20 2018 -0400 > > > > > > > > > > efl: use efl_add_ref to create objects which have no parent > > > > > > > > > > Signed-off-by: Mike Blumenkrantz <zm...@osg.samsung.com> > > > > > > > > > > > > > This is the third patch of patches I see that have Cedric as author and > > > > a > > > > sign off by Mike. > > > > > > > > We have no document backing the signed off by line. No document > > > > describing > > > > developer certificate of origin (DCO) at all. Thus I ask you to stop > > > > using signed off by tags here. > > > > > > indeed we've never used anything like the above. > > > > I have been using for more than a year Signed-off-by as a mean for reviewed. > > Check all the patch I have pushed last year from phab. This was me being > > lazy > > as there is no way from the default git command to append automatically a > > Reviewed-by tag and as no one else was doing much on this and I needed an > > easy way to account for the reviewing, I went with that. I have now setup a > > local script that add the Reviewed-by line. > > but stefan is still right that we have never documented the signed-off line > with a DCO etc. that was it's original intent from kernel land, not as a > reviewed-by.
Agreed and fixed for future case. I should now have Reviewed-by line added when I push a patch that I review. > > > > If this aims to be a reviewed-by tag, please switch to using that tag. > > > > If Mike is the author he should be listed as such and git will reference > > > > Cedric as committer. > > > > > > at least if going via phab ... the log will contain this (Reviewed-by). > > > > No. Phab doesn't add any line. It says reviewer and if you look at who > > pushed > > ok - sorry. I was wrong. it's "Reviewers". it does add who is doing the review > to the log. but it tells me who in the git commits mailing list: > > sanghyeonlee pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=2bad5fffce2474a80a1173448b1be10c9c7b1949 > > commit 2bad5fffce2474a80a1173448b1be10c9c7b1949 > Author: subhransu mohanty sub.moha...@samsung.com > Date: Wed Feb 28 15:15:20 2018 +0900 > > eina/bezier: use FLT_EQ marcro for float equal comparison. > > Reviewers: SanghyeonLee, jpeg, cedric > > Subscribers: cedric > > Differential Revision: https://phab.enlightenment.org/D5828 > > i see potential reviewers and who actually pushed it. Yup, exactly. > > the patch in the tree, you might be able to infer who did the last review. > > But that wasn't very nice to process, so I went with the above. It is fixed > > now. Cedric ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
