yeah I apologize what happen in my patch. I should have checked it more
delicately.
I just notice that problem on now.
Thank you very much and I'll be careful in next time for sure.

Regards
sanghyeon lee

2018년 4월 5일 (목) 오후 9:38, Stefan Schmidt <ste...@osg.samsung.com>님이 작성:

> Hello.
>
>
> On 04/04/2018 12:14 PM, SangHyeon Lee wrote:
> > sanghyeonlee pushed a commit to branch master.
> >
> >
> http://git.enlightenment.org/core/efl.git/commit/?id=ae8df9ba076e6086900353f0e10480bb2302b44d
> >
> > commit ae8df9ba076e6086900353f0e10480bb2302b44d
> > Author: SangHyeon Lee <sh10233....@samsung.com>
> > Date:   Wed Apr 4 19:04:43 2018 +0900
> >
> >     efl_ui_view_list : change the name of Model based list
> >
> >     Summary:
> >     model based list need to be under the namespace of 'Efl.Ui.View".
> >     thus, I renamed 'Efl.Ui.List' to 'Efl.Ui.View.List' properly.
> >
> >     Test Plan: N/A
> >
> >     Reviewers: cedric, felipealmeida
> >
> >     Differential Revision: https://phab.enlightenment.org/D5855
> > ---
> >  data/elementary/themes/edc/efl/list.edc            |   2 +-
> >  src/Makefile_Elementary.am                         |  24 +-
> >  ...st_example.edc => efl_ui_view_list_example.edc} |   0
> >  ...st_example_1.c => efl_ui_view_list_example_1.c} |  14 +-
> >  ...st_example_2.c => efl_ui_view_list_example_2.c} |  10 +-
> >  ...st_example_3.c => efl_ui_view_list_example_3.c} |  24 +-
>
> You renamed the files but did not rename the filennames in the Makefile.
> This broke the build of the examples.
>
> If you are pushing such a big patch I would expect you to run make
> examples if you changed something there to make at least sure it compiles.
>
> I am fixing this right now.
>
> regards
> Stefan Schmidt
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to