On Fri, 6 Apr 2018 10:24:42 +0200 Marcel Hollerbach <m...@bu5hm4n.de> said:

> Can you add that as comment in the code? I bet someone will forget that 
> and "fix" a leak otherwise :)

i can. :)

> Greetings,
>     bu5hm4n
> 
> On 04/06/2018 10:11 AM, Carsten Haitzler wrote:
> > raster pushed a commit to branch master.
> > 
> > http://git.enlightenment.org/core/efl.git/commit/?id=35a6e7a6d2dc26bc1f26ed66a10035ff217a7489
> > 
> > commit 35a6e7a6d2dc26bc1f26ed66a10035ff217a7489
> > Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com>
> > Date:   Fri Apr 6 17:08:44 2018 +0900
> > 
> >      ecore audio - dont unload modules etc. in case audio obj around on exit
> >      
> >      if audio objects are around after ecore_audio has been shut down then
> >      they may access the sndfile or pulse lib ptrs/funcs and thus dont
> >      unload these. should fix crashes on shutdown.
> > ---
> >   src/lib/ecore_audio/ecore_audio.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/lib/ecore_audio/ecore_audio.c
> > b/src/lib/ecore_audio/ecore_audio.c index e083b884fe..f62560f2e7 100644
> > --- a/src/lib/ecore_audio/ecore_audio.c
> > +++ b/src/lib/ecore_audio/ecore_audio.c
> > @@ -68,10 +68,10 @@ ecore_audio_shutdown(void)
> >        return _ecore_audio_init_count;
> >   
> >   #ifdef HAVE_SNDFILE
> > -   ecore_audio_sndfile_lib_unload();
> > +//   ecore_audio_sndfile_lib_unload();
> >   #endif /* HAVE_SNDFILE */
> >   #ifdef HAVE_PULSE
> > -   ecore_audio_pulse_lib_unload();
> > +//   ecore_audio_pulse_lib_unload();
> >   #endif /* HAVE_PULSE */
> >   
> >      /* FIXME: Shutdown all the inputs and outputs first */
> > 
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
Carsten Haitzler - ras...@rasterman.com


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to