On Wed, 11 Apr 2018 13:21:22 -0300 Gustavo Sverzut Barbieri
<barbi...@gmail.com> said:

> On Wed, Apr 11, 2018 at 2:43 AM, Carsten Haitzler <ras...@rasterman.com>
> wrote:
> >
> > raster pushed a commit to branch master.
> >
> > http://git.enlightenment.org/core/efl.git/commit/?id=86c855bdd356550513bf2b316961eceace107291
> >
> > commit 86c855bdd356550513bf2b316961eceace107291
> > Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com>
> > Date:   Wed Apr 11 14:34:40 2018 +0900
> >
> >     ecore ipc - fix send to skip data payload if null/0
> >
> >     conversion to efl.nmet didnt deal with null/0 zised payloads properly
> >     and tried to send them, resulting in lots of ERR complaints which were
> >     not errors. fix that to not try and send such empty payloads
> >
> >     @fix
> 
> i guess this is due the incorrect code that handled `data == NULL ||
> size == 0` as errors at efl-io-writer implementations...

that is a good question - should it be an error to senyt a null/0 size buffer.
for ipc there was a header with opcodes etc. and then a payload and just the
payload was empty and that was totally valid, so of course skipping the write
there makes sense.

so are you saying thjat writing a null/0 sized slice shouldnt result in an
error complaint at the efl.io.writer side?

> IMO should be only no-ops, so people don't have to spread this kind of
> code at call sites.
> 
> 
> -- 
> Gustavo Sverzut Barbieri
> --------------------------------------
> Mobile: +55 (16) 99354-9890
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
Carsten Haitzler - ras...@rasterman.com


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to