On Mon, 28 May 2018 19:55:55 +0200 Marcel Hollerbach <m...@bu5hm4n.de> wrote:
> Hello, > > D6224, D6223, D6222 are fixing the issue. (Or at least the cases i > have seen). > > However, could you stop acting up like this & writing mails like > this? Maybe there needs to be more so others do not do such things? > The lifetime of eo objects have been quite a mess, this branch > brought a bit light into the dark, it was not perfect how it came, > sure, I think all should focus more on the breakage than the reaction. Breaking things is bad m'kay... A few have reported breakage already. That never reflects well on a project much less any TEAM. > however here it is. Further more, you claim that this is not > personal, why was it then not enough to create a ticket, or simply a > revert revision to discuss things? It seemed like considerable time was spent trying to find a commit to revert or a a series. How much time should another spend? Should things be broken like this in the first place? With several reporting breakage already, and more likely to experience such. > Doing patches in EFL had always a team flavor for me, mails like > this are destroying that feeling. So in the end: Could we stop this > stupid blame team and start to act as a team again? Dropping a series of some 121 commits at once does not seem to team friendly to me. Unless the work is perfect or well tested and reviewed. There was already a discussion on reviews. If you say 1 minute per commit, that is 2 hours of review... If there is a discussion on any or needs testing modification etc. You are talking many hours... Not to mention with a upcoming release. Unless a bunch of stuff was broken and this fixes all that. Then really should be less than more. Every fix could potentially break something else. This seems like it caused way more issues than it fixed. Hard to defend. I think the reaction of waiting a few days and giving the author and TEAM a chance to fix is more than adequate and being overly nice. Not to mention effort put forth to fix, revert, etc already. I would not have been surprised if the commits were reverted right away. But a more diplomatic approach was taken. That is nice enough IMHO. People really need to get thick skin again. Its ok for a team member or project lead to be harsh on others for things. Surely for large patch sets and breaking stuff.... I have seen others lose it in public venues over much less... This being overly nice is why stuff like this can happen and others think its ok. I think the reaction would change things so such does not happen again. Then no reaction, no problem. -- William L. Thomson Jr.
pgphC7V1g6pIM.pgp
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
