While it is true that a mail was sent by JackDanielz related to this patch, the elapsed time between that mail and this revert is roughly 1.5 hours on a Saturday afternoon during a federal holiday weekend. If inactivity from a patch author is going to be used as reasoning for a revert, I think that the time period given should be a reasonable one.
As stated in the original thread, testing for this patch occurred on a number of machines, all with a similar quirk: modesetting occurs at the start of every session. This happened to work around the issue exhibited in some sessions. It's a bit unlucky, but that's the sort of result that can be expected when there is no unit testing for the component being modified. Questioning the review process in your case seems like a bit of a slippery slope considering that the patch was submitted over 3 weeks ago with you as a reviewer, and it was mentioned more than once in another ticket that you were active in at that time. Had the commit log for this revert been only "this patch causes this regression" with a simple description of the issue, it's unlikely that this mail would exist. Instead, however, it seems like this revert was being used to bash both patch review and testing--something which makes little sense considering that you declined to attempt either when it was explicitly requested of you. I don't think it's fair for you to (indirectly) criticize Cedric for trying to do the work that you did not do. I can understand your mindset in writing this commit log and related mail, but I don't think statements like these are beneficial to us as a community or the project as a whole. On Sat, May 26, 2018 at 4:01 PM Carsten Haitzler <ras...@rasterman.com> wrote: > raster pushed a commit to branch master. > > > http://git.enlightenment.org/core/efl.git/commit/?id=4715c099ecb1e9a5c7de5dab883560e198704c72 > > commit 4715c099ecb1e9a5c7de5dab883560e198704c72 > Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com> > Date: Sun May 27 04:52:03 2018 +0900 > > Revert "ecore-evas-x: set draw_block until the window receives a > configure event" > > This reverts commit 7b80038fa7b54cff27b463382283211727aaf104. > > JackDanielz asked nicely, but this hasn't been reverted. As this > totally breaks enlightenment (it's black) and this happens on > everythng I've tested (1 laptop, desktop and Xephyr) I'm calling this > patch a dud. > > Now... what kind of review is going on here? This hasn't been tested. > What kind of review doesn't build + run things? > > for the reasons of poor review and massive horribler fully complete > desktop like breakage ... this gets reverted as master should not be > broken like this. > --- > src/modules/ecore_evas/engines/x/ecore_evas_x.c | 27 > ++----------------------- > 1 file changed, 2 insertions(+), 25 deletions(-) > > diff --git a/src/modules/ecore_evas/engines/x/ecore_evas_x.c > b/src/modules/ecore_evas/engines/x/ecore_evas_x.c > index 47baeff5ff..3d88e9aae3 100644 > --- a/src/modules/ecore_evas/engines/x/ecore_evas_x.c > +++ b/src/modules/ecore_evas/engines/x/ecore_evas_x.c > > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
