On 7/16/06, The Rasterman Carsten Haitzler <[EMAIL PROTECTED]> wrote:
On Sun, 16 Jul 2006 09:43:03 -0200 "Chady Kassouf" <[EMAIL PROTECTED]>
babbled:
> Hi,
>
> I'm not sure if this is the same problem that was talked about earlier, but
> I got accross a strange bug.
> Steps to reproduce:
>
> 1- open a window
> 2- make the window sticky
> 3- Send the window to another desktop.
>
> Now there will be a ghost window sticking around.
interesting - send to desktop should actually be entirely useless if sticky
anyway... shoudl remove the menu in that case - will note down.
sorry about that, I probably had some stale object files somewhere, because I just recompiled and I cannot reproduce the error anymore.
In any case, here's a patch to remove the menu if the border is sticky.
Also, a patch to fix one TODO item, make the pager honor the window lock.
--
Chady 'Leviathan' Kassouf
http://chady.net/
Index: e_int_border_menu.c
===================================================================
RCS file: /cvs/e/e17/apps/e/src/bin/e_int_border_menu.c,v
retrieving revision 1.28
diff -u -r1.28 e_int_border_menu.c
--- e_int_border_menu.c 2 Jul 2006 16:19:51 -0000 1.28
+++ e_int_border_menu.c 16 Jul 2006 18:25:14 -0000
@@ -147,17 +147,20 @@
(char *)e_theme_edje_file_get("base/theme/borders",
"widgets/border/default/borders"),
"widgets/border/default/borders");
- mi = e_menu_item_new(m);
- e_menu_item_separator_set(mi, 1);
- mi = e_menu_item_new(m);
- e_menu_item_label_set(mi, _("Send to Desktop"));
- e_menu_item_submenu_pre_callback_set(mi, _e_border_menu_cb_sendto_pre, bd);
- e_menu_item_icon_edje_set(mi,
+ if (!bd->sticky)
+ {
+ mi = e_menu_item_new(m);
+ e_menu_item_separator_set(mi, 1);
+
+ mi = e_menu_item_new(m);
+ e_menu_item_label_set(mi, _("Send to Desktop"));
+ e_menu_item_submenu_pre_callback_set(mi, _e_border_menu_cb_sendto_pre,
bd);
+ e_menu_item_icon_edje_set(mi,
(char *)e_theme_edje_file_get("base/theme/borders",
"widgets/border/default/sendto"),
"widgets/border/default/sendto");
-
+ }
mi = e_menu_item_new(m);
e_menu_item_separator_set(mi, 1);
Index: TODO
===================================================================
RCS file: /cvs/e/e17/apps/e/TODO,v
retrieving revision 1.365
diff -u -r1.365 TODO
--- TODO 14 Jul 2006 20:01:47 -0000 1.365
+++ TODO 16 Jul 2006 18:19:34 -0000
@@ -30,8 +30,6 @@
a big xev (xev -g 1280x1024) that won't fit it gets placed offscreen to the
right of zone 2
* BUG: Hiding the label of e_widget_slider causes the slider line to disappear
-* BUG: Window locks should be honored by the pager (e.g. Lock me from
- changing position)
* BUG: in screen resolution change dialog the flip config is a pair of raidio
buttons. it should be a pair of checkboxes to turn that flip bit on or
off etc. etc. this means adding check icon widgets too liek radio icons too
Index: src/modules/pager/e_mod_main.c
===================================================================
RCS file: /cvs/e/e17/apps/e/src/modules/pager/e_mod_main.c,v
retrieving revision 1.179
diff -u -r1.179 e_mod_main.c
--- src/modules/pager/e_mod_main.c 2 Jul 2006 18:55:32 -0000 1.179
+++ src/modules/pager/e_mod_main.c 16 Jul 2006 18:19:52 -0000
@@ -1286,6 +1286,7 @@
ev = event_info;
pw = data;
if (!pw) return;
+ if (pw->border->lock_user_location) return;
/* FIXME: make this configurable */
if ((ev->button == 1) || (ev->button == 2))
{
------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
