On Mon, 29 Oct 2018 20:11:29 +0100 Marcel Hollerbach <m...@bu5hm4n.de> said:
> This cannot be true - as the list this was added to does not contain a > single file that is used via "#include ....eo.legacy.h" ... you can argue with the compiler errors all day if u want... :) but it was true. i didn't do this for no reason. i had #include xxxxlegacy.h not found and compiled failed. > Can you check again if this is really needed ? I cannot get a build > error with missing headers when this is reverted... indeed i can't see the error right now - but it did happen. i will try on my laptop too to be sure, but it did happen. > On 10/29/18 7:11 PM, Carsten Haitzler (The Rasterman) wrote: > > On Fri, 26 Oct 2018 18:19:01 +0200 Marcel Hollerbach <m...@bu5hm4n.de> said: > > > >> Can you elaborate why this is required ? > > > > the build literally breaks missing #included xxxlegacy.h files as they are > > not generated... these #includes are not in ifdefs. > > > >> #1 -gchd does not instruct eolian_gen to generate legacy headers. > >> #2 I cannot find a single file including the .eo.legacy.h files of those > >> #3 Reverting this does not bring up a single build error for me. > > > > i did this due to build errors with missing headers. > > > >> Greetings, > >> bu5hm4n > >> > >> > >> On 10/26/18 5:09 PM, Carsten Haitzler wrote: > >>> raster pushed a commit to branch master. > >>> > >>> http://git.enlightenment.org/core/efl.git/commit/?id=9aeedc5a1c68a5e28dcd12db5ee1856b33e19e45 > >>> > >>> commit 9aeedc5a1c68a5e28dcd12db5ee1856b33e19e45 > >>> Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com> > >>> Date: Thu Oct 25 00:19:46 2018 +0100 > >>> > >>> build - meson - fix build when legacy is still enabled and gen the > >>> code > >>> meson build was not generating .legacy.h etc. files for a whole host > >>> of classes that were depended on - add it back so the build works > >>> again. > >>> --- > >>> src/lib/elementary/meson.build | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/src/lib/elementary/meson.build > >>> b/src/lib/elementary/meson.build index 2b14c77853..1948e2ab9e 100644 > >>> --- a/src/lib/elementary/meson.build > >>> +++ b/src/lib/elementary/meson.build > >>> @@ -342,6 +342,7 @@ foreach eo_file : priv_eo_files > >>> command : [eolian_gen, '-I', meson.current_source_dir(), > >>> eolian_include_directories, '-o', 'h:' + > >>> join_paths(meson.current_build_dir(), eo_file + '.h'), '-o', 'c:' + > >>> join_paths(meson.current_build_dir(), eo_file + '.c'), > >>> + '-o', 'l:' + > >>> join_paths(meson.current_build_dir(), eo_file + '.legacy.h'), '-o', 'd:' + > >>> join_paths(meson.current_build_dir(), eo_file + '.d'), '-gchd', > >>> '@INPUT@']) endforeach > >>> > >> > >> > >> _______________________________________________ > >> enlightenment-devel mailing list > >> enlightenment-devel@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> > > > > > > > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- Carsten Haitzler - ras...@rasterman.com _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
