On 3/26/19 9:30 AM, Mike Blumenkrantz wrote: Hi,
It's been a week with no opposition so it seems fine for this to be merged. Mike Appreciate the input :) This was all actually merged on Friday so we can consider this thread closed. Cheers, dh On Sat, Mar 23, 2019 at 5:56 AM Carsten Haitzler [1]<[email protected]> wrote: On Tue, 19 Mar 2019 10:34:15 -0400 Christopher Michael < [2][email protected]> said: Hi All, Output rotation has been broken (when using the drm engines) for a little while now. I have fixes for both software & hardware engines (drm and gl_drm) all ready to go on [1][3]https://phab.enlightenment.org/T7690. Some of these patches have already been reviewed & accepted, others are still pending review. YAY! well done dh! In my opinion, it would be really nice to get this fixes reviewed, accepted and pushed before the release goes out. There is however one point of contention ... [2][4]https://phab.enlightenment.org/D8114 ... This patch adds One new API inside ecore_drm2 that Enlightenment needs in order to make output rotation functional. It is a small code addition that should not affect anything else in the release, however it IS a new API addition. Basically, I am wondering if we can get these patches reviewed and pushed, and perhaps a small exception for the API addition, before release ?? I realize that we are not supposed to add new API when we are frozen, but I am asking for a small exception in this case.. It was pretty clear years ago - a bugfix that requires an API change (that doesn't break previous stable APIs in prior releases) is OK as it's necessary for that fix. As long as it's necessary. :) Thoughts ?? dh References 1. [5]https://phab.enlightenment.org/T7690 2. [6]https://phab.enlightenment.org/D8114 _______________________________________________ enlightenment-devel mailing list [7][email protected] [8]https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- Carsten Haitzler - [9][email protected] _______________________________________________ enlightenment-devel mailing list [10][email protected] [11]https://lists.sourceforge.net/lists/listinfo/enlightenment-devel _______________________________________________ enlightenment-devel mailing list [12][email protected] [13]https://lists.sourceforge.net/lists/listinfo/enlightenment-devel References 1. mailto:[email protected] 2. mailto:[email protected] 3. https://phab.enlightenment.org/T7690 4. https://phab.enlightenment.org/D8114 5. https://phab.enlightenment.org/T7690 6. https://phab.enlightenment.org/D8114 7. mailto:[email protected] 8. https://lists.sourceforge.net/lists/listinfo/enlightenment-devel 9. mailto:[email protected] 10. mailto:[email protected] 11. https://lists.sourceforge.net/lists/listinfo/enlightenment-devel 12. mailto:[email protected] 13. https://lists.sourceforge.net/lists/listinfo/enlightenment-devel _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
