hermet pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=e851aa6e5279bc27545eb60a227a0d41acb637c4
commit e851aa6e5279bc27545eb60a227a0d41acb637c4 Author: Vincent Torri <[email protected]> Date: Thu May 23 20:25:27 2019 +0900 Emotion gst1 module: fix "empty if statement" warning Summary: the macro GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS can be undefined (see gst core doc), hence the if statement may have no body Test Plan: compilation Reviewers: zmike, raster, cedric, Hermet Reviewed By: Hermet Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8939 --- src/modules/emotion/gstreamer1/emotion_gstreamer.c | 29 +++++++++++++++++----- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/src/modules/emotion/gstreamer1/emotion_gstreamer.c b/src/modules/emotion/gstreamer1/emotion_gstreamer.c index f3118c7969..2def4d70d3 100644 --- a/src/modules/emotion/gstreamer1/emotion_gstreamer.c +++ b/src/modules/emotion/gstreamer1/emotion_gstreamer.c @@ -1563,9 +1563,11 @@ _bus_main_handler(void *data) #endif { if (getenv("EMOTION_GSTREAMER_DOT")) - GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(ev->pipeline), - GST_DEBUG_GRAPH_SHOW_ALL, - getenv("EMOTION_GSTREAMER_DOT")); + { + GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(ev->pipeline), + GST_DEBUG_GRAPH_SHOW_ALL, + getenv("EMOTION_GSTREAMER_DOT")); + } } _emotion_open_done(ev->obj); @@ -1701,7 +1703,12 @@ _emotion_gstreamer_cancel(void *data, Ecore_Thread *thread) if (getuid() == geteuid()) #endif { - if (getenv("EMOTION_GSTREAMER_DOT")) GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(ev->pipeline), GST_DEBUG_GRAPH_SHOW_ALL, getenv("EMOTION_GSTREAMER_DOT")); + if (getenv("EMOTION_GSTREAMER_DOT")) + { + GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(ev->pipeline), + GST_DEBUG_GRAPH_SHOW_ALL, + getenv("EMOTION_GSTREAMER_DOT")); + } } emotion_gstreamer_unref(ev); @@ -1723,7 +1730,12 @@ _emotion_gstreamer_end(void *data, Ecore_Thread *thread) if (getuid() == geteuid()) #endif { - if (getenv("EMOTION_GSTREAMER_DOT")) GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(ev->pipeline), GST_DEBUG_GRAPH_SHOW_ALL, getenv("EMOTION_GSTREAMER_DOT")); + if (getenv("EMOTION_GSTREAMER_DOT")) + { + GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(ev->pipeline), + GST_DEBUG_GRAPH_SHOW_ALL, + getenv("EMOTION_GSTREAMER_DOT")); + } } emotion_gstreamer_unref(ev); @@ -1791,7 +1803,12 @@ _create_pipeline(Emotion_Gstreamer *ev, if (getuid() == geteuid()) #endif { - if (getenv("EMOTION_GSTREAMER_DOT")) GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(playbin), GST_DEBUG_GRAPH_SHOW_ALL, getenv("EMOTION_GSTREAMER_DOT")); + if (getenv("EMOTION_GSTREAMER_DOT")) + { + GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(playbin), + GST_DEBUG_GRAPH_SHOW_ALL, + getenv("EMOTION_GSTREAMER_DOT")); + } } return playbin; --
