zmike pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=bd5d9573641fb8fc9a1c2c4b549645b515ae3502

commit bd5d9573641fb8fc9a1c2c4b549645b515ae3502
Author: Mike Blumenkrantz <[email protected]>
Date:   Wed May 29 09:18:09 2019 -0400

    elm/hovers: don't trigger more errors when setting null hover parent
    
    Summary:
    null is not a valid subobject, do not attempt to add it
    
    @fix
    Depends on D8963
    
    Reviewers: devilhorns
    
    Reviewed By: devilhorns
    
    Subscribers: devilhorns, cedric, #reviewers, #committers
    
    Tags: #efl
    
    Differential Revision: https://phab.enlightenment.org/D8964
---
 src/lib/elementary/elm_hover.c  | 3 ++-
 src/lib/elementary/elm_notify.c | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/lib/elementary/elm_hover.c b/src/lib/elementary/elm_hover.c
index 80c234a568..446cc508b5 100644
--- a/src/lib/elementary/elm_hover.c
+++ b/src/lib/elementary/elm_hover.c
@@ -759,7 +759,8 @@ elm_hover_parent_set(Evas_Object *obj,
 {
    ELM_HOVER_CHECK(obj);
    ELM_HOVER_DATA_GET(obj, sd);
-   efl_ui_widget_sub_object_add(parent, obj);
+   if (parent)
+     efl_ui_widget_sub_object_add(parent, obj);
    _parent_setup(obj, sd, parent);
 }
 
diff --git a/src/lib/elementary/elm_notify.c b/src/lib/elementary/elm_notify.c
index 0f1bbd37f4..ee734b9e39 100644
--- a/src/lib/elementary/elm_notify.c
+++ b/src/lib/elementary/elm_notify.c
@@ -537,7 +537,8 @@ elm_notify_parent_set(Evas_Object *obj,
 {
    ELM_NOTIFY_CHECK(obj);
    ELM_NOTIFY_DATA_GET(obj, sd);
-   efl_ui_widget_sub_object_add(parent, obj);
+   if (parent)
+     efl_ui_widget_sub_object_add(parent, obj);
    _parent_setup(obj, sd, parent);
 }
 

-- 


Reply via email to