zmike pushed a commit to branch efl-1.22. http://git.enlightenment.org/core/efl.git/commit/?id=97f8c738efbe41f29e2b675a8c85dd334248e701
commit 97f8c738efbe41f29e2b675a8c85dd334248e701 Author: Mike Blumenkrantz <[email protected]> Date: Wed May 29 09:23:44 2019 -0400 eldbus: don't print warnings for user-canceled calls Summary: these are intentionally canceled and not something to be concerned with @fix Depends on D8974 Reviewers: devilhorns Reviewed By: devilhorns Subscribers: cedric, #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D8976 --- src/lib/eldbus/eldbus_proxy.c | 6 ++++-- src/lib/elementary/elm_atspi_bridge.c | 4 +++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/lib/eldbus/eldbus_proxy.c b/src/lib/eldbus/eldbus_proxy.c index fdd4fc7b3a..a28fe9f0e4 100644 --- a/src/lib/eldbus/eldbus_proxy.c +++ b/src/lib/eldbus/eldbus_proxy.c @@ -814,8 +814,10 @@ _props_get_all(void *data, const Eldbus_Message *msg, Eldbus_Pending *pending) if (eldbus_message_error_get(msg, &name, &error_msg)) { - WRN("Error getting all properties of %s %s, error message: %s %s", - proxy->obj->name, proxy->obj->path, name, error_msg); + /* don't print warnings for user-canceled calls */ + if (!eina_streq(name, "org.enlightenment.DBus.Canceled")) + WRN("Error getting all properties of %s %s, error message: %s %s", + proxy->obj->name, proxy->obj->path, name, error_msg); return; } diff --git a/src/lib/elementary/elm_atspi_bridge.c b/src/lib/elementary/elm_atspi_bridge.c index 9341b64981..6ec5fd7729 100644 --- a/src/lib/elementary/elm_atspi_bridge.c +++ b/src/lib/elementary/elm_atspi_bridge.c @@ -4510,7 +4510,9 @@ _screen_reader_enabled_get(void *data, const Eldbus_Message *msg, Eldbus_Pending if (eldbus_message_error_get(msg, &errname, &errmsg)) { - WRN("%s %s", errname, errmsg); + /* don't print warnings for user-canceled calls */ + if (!eina_streq(errname, "org.enlightenment.DBus.Canceled")) + WRN("%s %s", errname, errmsg); return; } if (!eldbus_message_arguments_get(msg, "v", &variant)) --
