Do you have plans to look into this? It would be ideal if all unit tests can be run regularly.
On Wed, Jul 17, 2019 at 8:53 AM Christopher Michael <[email protected]> wrote: > Yes, this does mean that it will not run on Travis. Before this commit, > Travis was trying to build these tests however they kept failing (possibly > due to Travis configuration) and Marcel suggested this patch to fix the > Travis build failures. > > On 7/17/19 8:48 AM, Mike Blumenkrantz wrote: > > Hi, > > Doesn't this also mean that it won't run on travis? I think ideally we do > want unit tests to be run on CI... > > > > On Wed, Jul 17, 2019 at 4:44 AM Christopher Michael <[email protected]> > <[email protected]> > wrote: > > > devilhorns pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=af0a37da03a77a96e187fd5c08debc6791b8b3c5 > > commit af0a37da03a77a96e187fd5c08debc6791b8b3c5 > Author: Christopher Michael <[email protected]> <[email protected]> > Date: Mon Jul 15 14:21:36 2019 -0400 > > tests/ecore_wl2: Check for valid xdg_runtime_dir > > Seems these tests need XDG_RUNTIME_DIR to be set, and it does not get > set in Travis builds, so add a small check here so that Travis builds > don't fail ... thanks Marcel ;) > > ref T8016 > --- > src/tests/ecore_wl2/ecore_wl2_test_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/tests/ecore_wl2/ecore_wl2_test_display.c > b/src/tests/ecore_wl2/ecore_wl2_test_display.c > index c90c944cb2..828db2f432 100644 > --- a/src/tests/ecore_wl2/ecore_wl2_test_display.c > +++ b/src/tests/ecore_wl2/ecore_wl2_test_display.c > @@ -165,7 +165,7 @@ EFL_END_TEST > void > ecore_wl2_test_display(TCase *tc) > { > - if (!getenv("WAYLAND_DISPLAY")) > + if ((!getenv("WAYLAND_DISPLAY")) && (getenv("XDG_RUNTIME_DIR"))) > { > /* tests here are for server-side functions */ > printf("No Wayland Compositor detected. Testing server-side > functions\n"); > > -- > > > > > _______________________________________________ > enlightenment-devel mailing > [email protected]https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
