raster pushed a commit to branch efl-1.22.

http://git.enlightenment.org/core/efl.git/commit/?id=8066c82b654ee43ac89b82da012520898291d548

commit 8066c82b654ee43ac89b82da012520898291d548
Author: Carsten Haitzler (Rasterman) <[email protected]>
Date:   Sat Aug 10 23:27:24 2019 +0100

    eina file - don't double unlock a lock
    
    thanks to coverity - found this double unlock path in case of error.
    
    fix CID 1403899
---
 src/lib/eina/eina_file.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/lib/eina/eina_file.c b/src/lib/eina/eina_file.c
index cc53f65cce..504f958482 100644
--- a/src/lib/eina/eina_file.c
+++ b/src/lib/eina/eina_file.c
@@ -832,10 +832,7 @@ eina_file_open(const char *path, Eina_Bool shared)
      {
         n = malloc(sizeof(Eina_File));
         if (!n)
-         {
-             eina_lock_release(&_eina_file_lock_cache);
-             goto on_error;
-         }
+          goto on_error;
 
         memset(n, 0, sizeof(Eina_File));
         n->filename = filename;

-- 


Reply via email to