q66 pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=b6815a2f998846fa0c53da3a142d406041109bf0
commit b6815a2f998846fa0c53da3a142d406041109bf0
Author: Daniel Kolesa <d.kol...@samsung.com>
Date: Tue Sep 10 14:17:25 2019 +0200
eolian: account for @by_ref when serializing return types
This fixes cases such as missing const when having a @by_ref
return type. The const should not be avoided there because it
is not returning the whole type as const, just what the pointer
dereferences to.
---
src/lib/eolian/database_type.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/eolian/database_type.c b/src/lib/eolian/database_type.c
index 6381cf8496..52973fb453 100644
--- a/src/lib/eolian/database_type.c
+++ b/src/lib/eolian/database_type.c
@@ -107,7 +107,7 @@ database_type_to_str(const Eolian_Type *tp,
|| tp->type == EOLIAN_TYPE_CLASS
|| tp->type == EOLIAN_TYPE_VOID)
&& tp->is_const
- && ((ctype != EOLIAN_C_TYPE_RETURN) || database_type_is_ownable(NULL, tp,
EINA_FALSE)))
+ && ((ctype != EOLIAN_C_TYPE_RETURN) || by_ref ||
database_type_is_ownable(NULL, tp, EINA_FALSE)))
{
eina_strbuf_append(buf, "const ");
}
--
