zmike pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=1d96fc92023c37af76f4c277c917911f059ae220

commit 1d96fc92023c37af76f4c277c917911f059ae220
Author: Shinwoo Kim <cinoo....@samsung.com>
Date:   Tue Sep 3 12:04:16 2019 -0400

    eina benchmarks: remove dereference of null
    
    Summary:
    A static analysis tool detects return value of malloc could be NULL and its
    following lines could have derefernece of NULL case.
    
    Reviewers: bu5hm4n, zmike, Hermet
    
    Reviewed By: zmike
    
    Subscribers: cedric, #reviewers, #committers
    
    Tags: #efl
    
    Differential Revision: https://phab.enlightenment.org/D9812
---
 src/benchmarks/eina/ecore_strings.c | 1 +
 src/benchmarks/eina/evas_mempool.c  | 1 +
 2 files changed, 2 insertions(+)

diff --git a/src/benchmarks/eina/ecore_strings.c 
b/src/benchmarks/eina/ecore_strings.c
index 15deae6b8f..e56235226c 100644
--- a/src/benchmarks/eina/ecore_strings.c
+++ b/src/benchmarks/eina/ecore_strings.c
@@ -83,6 +83,7 @@ ecore_string_instance(const char *string)
 
         str =
            (Ecore_String *)malloc(sizeof(Ecore_String) + length * 
sizeof(char));
+        if (!str) return NULL;
 
         str->string = (char *)(str + 1);
         str->references = 0;
diff --git a/src/benchmarks/eina/evas_mempool.c 
b/src/benchmarks/eina/evas_mempool.c
index 40df42fd25..156a36f916 100644
--- a/src/benchmarks/eina/evas_mempool.c
+++ b/src/benchmarks/eina/evas_mempool.c
@@ -40,6 +40,7 @@ _evas_mp_pool_new(Evas_Mempool *pool)
    item_alloc =
       ((pool->item_size + sizeof(void *) - 1) / sizeof(void *)) * sizeof(void 
*);
    p = malloc(sizeof(Pool) + (pool->pool_size * item_alloc));
+   if (!p) return NULL;
    ptr = (void **)(((unsigned char *)p) + sizeof(Pool));
    p->usage = 0;
    p->base = ptr;

-- 


Reply via email to