xartigas pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=b1e697df1c57005219011f65178e3ea7a01db5f5
commit b1e697df1c57005219011f65178e3ea7a01db5f5
Author: Jaehyun Cho <jae_hyun....@samsung.com>
Date: Fri Aug 2 10:43:45 2019 +0200
efl_input_clickable: increase the time interval for repeated counter
Summary:
The repeated counter in Efl.Input.Clickable_Clicked can be used to
identify double click or triple click.
Previously, the repeated counter in Efl.Input.Clickable_Clicked was
calculated within the time interval 0.1 second.
Now, the time interval for the repeated counter is increased to 0.25
second. It seems that 0.25 second is more appropriate to identify if the
two consecutive clicks should be considered together.
(e.g. considered as double click or triple click)
Moreover, in ecore_event and edje, 0.25 second is already used as a time
interval for double click.
Test Plan:
1. Run Efl.Ui.Button in elementary_test
2. Do double click or triple click the buttons
Reviewers: segfaultxavi, bu5hm4n, YOhoho
Reviewed By: segfaultxavi, YOhoho
Subscribers: YOhoho, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9485
---
src/bin/elementary/test_ui_button.c | 5 +++--
src/lib/evas/canvas/efl_input_clickable.c | 2 +-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/bin/elementary/test_ui_button.c
b/src/bin/elementary/test_ui_button.c
index 62be0bca4f..9571930f6f 100644
--- a/src/bin/elementary/test_ui_button.c
+++ b/src/bin/elementary/test_ui_button.c
@@ -5,9 +5,10 @@
#include <Elementary.h>
static void
-_clicked(void *data EINA_UNUSED, const Efl_Event *ev EINA_UNUSED)
+_clicked(void *data EINA_UNUSED, const Efl_Event *ev)
{
- printf("Button is clicked!!!\n");
+ Efl_Input_Clickable_Clicked *clicked = ev->info;
+ printf("Button is clicked!!! repeated(%d) button(%d)\n", clicked->repeated,
clicked->button);
}
static void
diff --git a/src/lib/evas/canvas/efl_input_clickable.c
b/src/lib/evas/canvas/efl_input_clickable.c
index cc248184bd..fc91803655 100644
--- a/src/lib/evas/canvas/efl_input_clickable.c
+++ b/src/lib/evas/canvas/efl_input_clickable.c
@@ -21,7 +21,7 @@ typedef struct {
#define MY_CLASS EFL_INPUT_CLICKABLE_MIXIN
-#define DOUBLE_CLICK_TIME ((double)0.1) //in seconds
+#define DOUBLE_CLICK_TIME ((double)0.25) //in seconds
#define LONGPRESS_TIMEOUT ((double)1.0) //in seconds
static void
--
