raster pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=b7bc6212bc5c71a9717e46f8a93467340e37abc6

commit b7bc6212bc5c71a9717e46f8a93467340e37abc6
Author: Carsten Haitzler (Rasterman) <[email protected]>
Date:   Mon Aug 5 14:38:10 2019 +0100

    ecore drm legacy - fix dbus leaks of reply handle
    
    fix CID 1402664
---
 src/lib/ecore_drm/ecore_drm_dbus.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/src/lib/ecore_drm/ecore_drm_dbus.c 
b/src/lib/ecore_drm/ecore_drm_dbus.c
index 7f333f0fc5..686c93c9eb 100644
--- a/src/lib/ecore_drm/ecore_drm_dbus.c
+++ b/src/lib/ecore_drm/ecore_drm_dbus.c
@@ -176,9 +176,11 @@ _ecore_drm_dbus_session_take(void)
    if (eldbus_message_error_get(reply, &errname, &errmsg))
      {
         ERR("Eldbus Message Error: %s %s", errname, errmsg);
+        eldbus_message_unref(reply);
         return EINA_FALSE;
      }
 
+   eldbus_message_unref(reply);
    return EINA_TRUE;
 }
 
@@ -207,9 +209,11 @@ _ecore_drm_dbus_session_release(void)
    if (eldbus_message_error_get(reply, &errname, &errmsg))
      {
         ERR("Eldbus Message Error: %s %s", errname, errmsg);
+        eldbus_message_unref(reply);
         return EINA_FALSE;
      }
 
+   eldbus_message_unref(reply);
    return EINA_TRUE;
 }
 
@@ -316,12 +320,17 @@ _ecore_drm_dbus_device_take_no_pending(uint32_t major, 
uint32_t minor, Eina_Bool
    if (eldbus_message_error_get(reply, &errname, &errmsg))
      {
         ERR("Eldbus Message Error: %s %s", errname, errmsg);
+        eldbus_message_unref(reply);
         return -1;
      }
 
    if (!eldbus_message_arguments_get(reply, "hb", &fd, &b))
-     return -1;
+     {
+        eldbus_message_unref(reply);
+        return -1;
+     }
 
+   eldbus_message_unref(reply);
    if (paused_out) *paused_out = b;
    return fd;
 }

-- 


Reply via email to