q66 pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=ede2db5f1b2bd8707c0cbb8a3024cf1a416863bb

commit ede2db5f1b2bd8707c0cbb8a3024cf1a416863bb
Author: Daniel Kolesa <[email protected]>
Date:   Mon Aug 5 15:32:15 2019 +0200

    eolian: attempt to silence coverity overlapping assignment errors
    
    While the previous code was I believe correct, coverity still
    complains about it. Split it into two statements also to declare
    intent.
    
    CID 1402603..1402724
---
 src/lib/eolian/database_expr.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/lib/eolian/database_expr.c b/src/lib/eolian/database_expr.c
index 14af0cfb08..c2b6030db1 100644
--- a/src/lib/eolian/database_expr.c
+++ b/src/lib/eolian/database_expr.c
@@ -120,8 +120,11 @@ static Eina_Bool
 promote(Eolian_Expression *a, Eolian_Expression *b)
 {
 #define CONVERT_CASE(id, dtp, expr, field, fnm) \
-   case EOLIAN_EXPR_##id: \
-     expr->value.field = (dtp)(expr->value.fnm); break;
+   case EOLIAN_EXPR_##id: { \
+      dtp nv = (dtp)(expr->value.fnm); \
+      expr->value.field = nv; \
+      break; \
+   }
 
 #define CONVERT(dtp, expr, field) \
    switch (expr->type) \

-- 


Reply via email to