xartigas pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=f4290cb330f8c594c460bb5fdbf36fcaf5459152
commit f4290cb330f8c594c460bb5fdbf36fcaf5459152 Author: Xavi Artigas <[email protected]> Date: Wed Sep 18 13:40:32 2019 +0200 Efl.ThreadIO: replace empty implementations with @pure_virtual The implementation for call and call_async are empty on this mixin. I think removing them and marking them as @pure_virtual in the EO file is cleaner. --- src/lib/ecore/efl_threadio.c | 11 ----------- src/lib/ecore/efl_threadio.eo | 4 ++-- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/src/lib/ecore/efl_threadio.c b/src/lib/ecore/efl_threadio.c index 96a2c4fa26..7d6c21cd26 100644 --- a/src/lib/ecore/efl_threadio.c +++ b/src/lib/ecore/efl_threadio.c @@ -43,17 +43,6 @@ _efl_threadio_outdata_get(const Eo *obj EINA_UNUSED, Efl_ThreadIO_Data *pd) return pd->outdata; } -EOLIAN static void -_efl_threadio_call(Eo *obj EINA_UNUSED, Efl_ThreadIO_Data *pd EINA_UNUSED, void *func_data EINA_UNUSED, EflThreadIOCall func EINA_UNUSED, Eina_Free_Cb func_free_cb EINA_UNUSED) -{ -} - -EOLIAN static void * -_efl_threadio_call_sync(Eo *obj EINA_UNUSED, Efl_ThreadIO_Data *pd EINA_UNUSED, void *func_data EINA_UNUSED, EflThreadIOCallSync func EINA_UNUSED, Eina_Free_Cb func_free_cb EINA_UNUSED) -{ - return NULL; -} - ////////////////////////////////////////////////////////////////////////// #include "efl_threadio.eo.c" diff --git a/src/lib/ecore/efl_threadio.eo b/src/lib/ecore/efl_threadio.eo index f8d778c59a..58629fd7b4 100644 --- a/src/lib/ecore/efl_threadio.eo +++ b/src/lib/ecore/efl_threadio.eo @@ -39,13 +39,13 @@ mixin @beta Efl.ThreadIO data: void_ptr; [[Data pointer.]] } } - call { + call @pure_virtual { [[Executes a method on a different thread, asynchronously.]] params { func: EflThreadIOCall; [[The method to execute asynchronously.]] } } - call_sync { + call_sync @pure_virtual { [[Executes a method on a different thread, synchronously. This call will not return until the method finishes and its return value can be recovered. ]] --
