Hi, I (and others) have been looking at this, but the amount of API to review is non-trivial and it is taking some time.
Regards, Mike On Thu, Sep 19, 2019 at 10:16 AM Tom Hacohen <[email protected]> wrote: > Hey, > > As most of you (at least the IRC lurkers) know, I've been recently > working on the text interfaces. Trying to clean them up and stabilise them. > The discussion and work has been covered on phab at: > https://phab.enlightenment.org/T8151 > > And the new (suggested) interfaces are all the files starting with > "efl2_" in my branch: > https://git.enlightenment.org/core/efl.git/tree/?h=devs/tasn/ifaces > > I'd love to get your feedback and let me know if there's anything I've > missed. All feedback is welcomed, including bike shedding. > Some interfaces still have massive FIXMEs at the top, so obviously read > those before replying to avoid repeating what we already know. > > > As for the advice I mentioned in the title: due to composite object > regressions as described in T8184, I'm forced to break up the classes > into interfaces. As discussed at length in the ticket, these interfaces > would have to be very specific to the classes and not really reusable > ("cursor_new" is quite specific, obviously). > > I can either just do as I said in the ticket, and for every class do a > big interface, so Efl.Canvas.Text -> Efl.Canvas.Text + > Efl.Canvas.Text_Interface. This is one way. It's obviously very ugly. > The other way is to split to a lot of smaller, probably 1/2 property > interfaces, which is also ugly and quite inefficient (classes/interfaces > are not free). > > I'd love to get your input, to what interfaces would you split up these > two classes: > 1. > > https://git.enlightenment.org/core/efl.git/tree/src/lib/evas/canvas/efl2_canvas_text.eo?h=devs/tasn/ifaces > 2. > > https://git.enlightenment.org/core/efl.git/tree/src/lib/elementary/efl2_text_raw_editable.eo?h=devs/tasn/ifaces > > > Thanks a lot for your help and feedback! > > -- > Tom > > > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
