xartigas pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=5256b9476d12c8057532de45a1500a3290649c7d

commit 5256b9476d12c8057532de45a1500a3290649c7d
Author: Mike Blumenkrantz <[email protected]>
Date:   Thu Sep 26 17:03:38 2019 +0200

    efl_ui/layout: improve error message when theme version parsing fails
    
    Summary:
    be very explicit here so that users can immediately know how to resolve
    the issue
    Depends on D10193
    
    Subscribers: cedric, #reviewers, #committers
    
    Tags: #efl
    
    Differential Revision: https://phab.enlightenment.org/D10194
---
 src/lib/elementary/efl_ui_layout.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/lib/elementary/efl_ui_layout.c 
b/src/lib/elementary/efl_ui_layout.c
index d25e86ccb2..5719d23c9f 100644
--- a/src/lib/elementary/efl_ui_layout.c
+++ b/src/lib/elementary/efl_ui_layout.c
@@ -575,6 +575,8 @@ _efl_ui_layout_base_efl_ui_widget_theme_apply(Eo *obj, 
Efl_Ui_Layout_Data *sd)
           {
              ERR("Widget(%p) with type '%s' is not providing a version in its 
theme!", obj,
                  efl_class_name_get(efl_class_get(obj)));
+             ERR("Group '%s' should have data.item: \"version\" \"%d%d\";",
+                 efl_file_key_get(wd->resize_obj), EFL_VERSION_MAJOR, 
EFL_VERSION_MINOR);
              return EFL_UI_THEME_APPLY_ERROR_VERSION;
           }
         else
@@ -585,6 +587,8 @@ _efl_ui_layout_base_efl_ui_widget_theme_apply(Eo *obj, 
Efl_Ui_Layout_Data *sd)
                {
                   ERR("Widget(%p) with type '%s' is not providing a valid 
version in its theme!", obj,
                       efl_class_name_get(efl_class_get(obj)));
+                  ERR("Group '%s' should have data.item: \"version\" 
\"%d%d\";",
+                       efl_file_key_get(wd->resize_obj), EFL_VERSION_MAJOR, 
EFL_VERSION_MINOR);
                   sd->version = 0;
                   return EFL_UI_THEME_APPLY_ERROR_VERSION;
                }

-- 


Reply via email to