On Sat, 05 Oct 2019 06:31:18 -0700 Boris Faure <[email protected]> said:

You forgot some signal to clear the bell state... :)

> billiob pushed a commit to branch master.
> 
> http://git.enlightenment.org/apps/terminology.git/commit/?id=a32b9cee884cf2a44b102a0c05eee2f9f26f7933
> 
> commit a32b9cee884cf2a44b102a0c05eee2f9f26f7933
> Author: Boris Faure <[email protected]>
> Date:   Sat Oct 5 15:29:56 2019 +0200
> 
>     tabs: show tabs that have a bell
> ---
>  ChangeLog.theme         |  7 ++++++-
>  data/themes/default.edc | 13 ++++++++++++-
>  src/bin/win.c           |  3 ++-
>  3 files changed, 20 insertions(+), 3 deletions(-)
> 
> diff --git a/ChangeLog.theme b/ChangeLog.theme
> index 7a18ef4..9b5d3d9 100644
> --- a/ChangeLog.theme
> +++ b/ChangeLog.theme
> @@ -1,7 +1,12 @@
>  =================
> -Terminology 1.5.0
> +Terminology 1.6.0
>  =================
>  
> +Changes since 1.5.0:
> +--------------------
> +  * In group "terminology/tabbar_back", add signal "bell" from "terminology"
> +  to mark a tab as having the bell on.
> +
>  Changes since 1.2.0:
>  --------------------
>    * Color class "BG" has to be set with the color of the background.
> diff --git a/data/themes/default.edc b/data/themes/default.edc
> index bd30d2e..ec3d475 100644
> --- a/data/themes/default.edc
> +++ b/data/themes/default.edc
> @@ -2116,7 +2116,7 @@ collections {
>           }
>           part { name: "terminology.title"; type: TEXT; mouse_events: 0;
>              scale: 1;
> -            effect: GLOW;
> +            effect: OUTLINE_SOFT_SHADOW;
>              description { state: "default" 0.0;
>                 text { font: "Sans:style=Bold"; size: 10;
>                    align: 0.5 0.5;
> @@ -2128,6 +2128,12 @@ collections {
>                 rel1.to: "tab_bevel_top2";
>                 rel2.to: "tab_bevel_top2";
>              }
> +            description { state: "bell" 0.0;
> +               inherit: "default" 0.0;
> +               color: 255 219 0 96;
> +               color2: 255 51 0 48;
> +               color3: 255 51 0 8;
> +            }
>           }
>           part { name: "clip"; type: RECT;
>              description { state: "default" 0.0;
> @@ -2143,6 +2149,11 @@ collections {
>              signal: "mouse,clicked,1"; source: "event";
>              action: SIGNAL_EMIT "tab,activate" "terminology";
>           }
> +         program { name: "bell";
> +            signal: "bell"; source: "terminology";
> +            action: STATE_SET "bell" 0.0;
> +            target: "terminology.title";
> +         }
>        }
>     }
>  
> diff --git a/src/bin/win.c b/src/bin/win.c
> index e90b542..be771e8 100644
> --- a/src/bin/win.c
> +++ b/src/bin/win.c
> @@ -2567,7 +2567,6 @@ _split_split(Term_Container *tc, Term_Container *child,
>     Term_Container *tc_split, *tc_solo_new;
>     Evas_Object *obj_split;
>  
> -   DBG(" ");
>     assert (tc->type == TERM_CONTAINER_TYPE_SPLIT);
>     split = (Split *)tc;
>     wn = tc->wn;
> @@ -2921,6 +2920,8 @@ _tabbar_fill(Tabs *tabs)
>                    term->tabbar.r.tabs =
> eina_list_append(term->tabbar.r.tabs, o);
> elm_box_pack_end(term->tabbar.r.box, o); }
> +             if (solo->term->missed_bell)
> +                 edje_object_signal_emit(o, "bell", "terminology");
>               evas_object_data_set(o, "term", term);
>               evas_object_show(o);
>               edje_object_signal_callback_add(o, "tab,activate",
> "terminology",
> 
> -- 
> 
> 


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
Carsten Haitzler - [email protected]



_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to