zmike pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=21f07b9fa980ffa181a0e88865236fc0c5bac9e7
commit 21f07b9fa980ffa181a0e88865236fc0c5bac9e7 Author: Cedric Bail <[email protected]> Date: Thu Oct 31 13:20:45 2019 -0400 evas: deprecate evas_device_parent_set. Summary: It is unlikely that the code was working before and it was a bad idea anyway. There is no user of this API in EFL. Depends on D10490 Reviewers: zmike, raster, bu5hm4n, Hermet Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Maniphest Tasks: T8321 Differential Revision: https://phab.enlightenment.org/D10491 --- src/lib/evas/Evas_Common.h | 2 +- src/lib/evas/canvas/evas_device.c | 17 ++--------------- 2 files changed, 3 insertions(+), 16 deletions(-) diff --git a/src/lib/evas/Evas_Common.h b/src/lib/evas/Evas_Common.h index f68f544dd3..632260fbe0 100644 --- a/src/lib/evas/Evas_Common.h +++ b/src/lib/evas/Evas_Common.h @@ -1159,7 +1159,7 @@ EAPI const char *evas_device_description_get(const Evas_Device *dev); * * @since 1.8 */ -EAPI void evas_device_parent_set(Evas_Device *dev, Evas_Device *parent); +EAPI void evas_device_parent_set(Evas_Device *dev, Evas_Device *parent) EINA_DEPRECATED; /** * Get the parent of a device diff --git a/src/lib/evas/canvas/evas_device.c b/src/lib/evas/canvas/evas_device.c index af95619044..1652e79100 100644 --- a/src/lib/evas/canvas/evas_device.c +++ b/src/lib/evas/canvas/evas_device.c @@ -330,25 +330,12 @@ evas_device_description_get(const Evas_Device *dev) } EAPI void -evas_device_parent_set(Evas_Device *dev, Evas_Device *parent) +evas_device_parent_set(Evas_Device *dev EINA_UNUSED, Evas_Device *parent EINA_UNUSED) { // Note: This function should be deprecated. parent_set doesn't make sense // unless the parent is a seat device. Parent shouldn't be changed after // creation. - - SAFETY_CHECK(dev, EFL_INPUT_DEVICE_CLASS); - - if (parent) - { - SAFETY_CHECK(parent, EFL_INPUT_DEVICE_CLASS); - } - else if (efl_parent_get(dev)) - { - efl_ref(dev); - } - - efl_parent_set(dev, parent); - evas_event_callback_call(efl_input_device_evas_get(dev), EVAS_CALLBACK_DEVICE_CHANGED, dev); + ERR("It is not advised and possible anymore to changed the parent of an Evas_Device."); } EAPI const Evas_Device * --
