cedric pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=f7c6bec38ff0a19bdffab249836faaf7a1824c47
commit f7c6bec38ff0a19bdffab249836faaf7a1824c47 Author: Cedric BAIL <[email protected]> Date: Fri Nov 1 08:03:00 2019 -0700 elementary: fix end of fast scroll not showing up during Efl.Ui.CollectionView scroll. efl_ui_position_manager_entity_entities_ready is expecting the end offset and not the length of how many items have been updated. Sending the correct number fixes the problem. Reviewed-by: Marcel Hollerbach <[email protected]> Reviewed-by: SangHyeon Jade Lee <[email protected]> Differential Revision: https://phab.enlightenment.org/D10590 --- src/lib/elementary/efl_ui_collection_view.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/lib/elementary/efl_ui_collection_view.c b/src/lib/elementary/efl_ui_collection_view.c index fa2dd423e9..3b7b8132ee 100644 --- a/src/lib/elementary/efl_ui_collection_view.c +++ b/src/lib/elementary/efl_ui_collection_view.c @@ -575,7 +575,6 @@ _entity_fetched_cb(Eo *obj, void *data, const Eina_Value v) } } #endif - // When requesting an entity, the model should already be in the cache if (!child) continue; @@ -624,8 +623,8 @@ _entity_fetched_cb(Eo *obj, void *data, const Eina_Value v) search_index - 1); updated_size = EINA_FALSE; } - }} - ; + } + } // Currently position manager will flush its entire size cache on update, so only do // it when necessary to improve performance. @@ -642,7 +641,7 @@ _entity_fetched_cb(Eo *obj, void *data, const Eina_Value v) { efl_ui_position_manager_entity_entities_ready(pd->manager, updated_entity_start_id, - i - 1); + request->offset + i - 1); efl_event_callback_del(efl_main_loop_get(), EFL_LOOP_EVENT_IDLE, _idle_cb, obj); efl_event_callback_add(efl_main_loop_get(), EFL_LOOP_EVENT_IDLE, _idle_cb, obj); @@ -1054,7 +1053,7 @@ _batch_entity_cb(void *data, Efl_Ui_Position_Manager_Request_Range range, Eina_R entities = memory.mem; //count = efl_model_children_count_get(parent); - limit = range.end_id - range.start_id;; + limit = range.end_id - range.start_id; // Look in the temporary cache now for the beginning of the buffer #ifdef VIEWPORT_ENABLE --
