[EGIT] [legacy/imlib2_loaders] master 06/06: ANI loader: Fix memory leak in error path

[Kim Woelders]

kwo pushed a commit to branch master.

http://git.enlightenment.org/legacy/imlib2_loaders.git/commit/?id=85287fcb3fb426ba2a10767af8ed780dd12467e2

commit 85287fcb3fb426ba2a10767af8ed780dd12467e2
Author: Kim Woelders <k...@woelders.dk>
Date:   Sun Nov 17 12:26:22 2019 +0100

    ANI loader: Fix memory leak in error path
---
 src/modules/loaders/loader_ani.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/modules/loaders/loader_ani.c b/src/modules/loaders/loader_ani.c
index c222e18..e7a1ac8 100644
--- a/src/modules/loaders/loader_ani.c
+++ b/src/modules/loaders/loader_ani.c
@@ -121,7 +121,7 @@ ani_init(char *filename)
       return NULL;
 
    if (!(ani->fp = fopen(filename, "r")))
-      return NULL;
+      goto bail;
 
    ani->filename = filename;
    ani->cp += ani_read_int32(ani->fp, &ani->riff_id, 1);
@@ -129,12 +129,13 @@ ani_init(char *filename)
    ani->cp += ani_read_int32(ani->fp, &ani->chunk_id, 1);
 
    if (ani->riff_id != 0x46464952 || ani->chunk_id != 0x4E4F4341)
-     {
-        ani_cleanup(ani);
-        return NULL;
-     }
+      goto bail;
 
    return ani;
+
+ bail:
+   ani_cleanup(ani);
+   return NULL;
 }
 
 static void

--