Ahhh ok. That makes complete and total sense then. I wasn't doubting
you, just wanted to see if it was a specific test case that was
failing.
"The sequence of problems is (as described in the revision that
introduces this):"
Yes, I didn't see any diff revision in your commit, so had to manually
track the diff down. No worries !
Cheers,
dh
On 1/20/20 12:20 PM, Marcel Hollerbach wrote:
Everything that starts a wayland window.
The sequence of problems is (as described in the revision that
introduces this):
- Module gets loaded, sets up a surface manager via
ecore_wl2_surface_manager_add.
- Module gets unloaded, registered surface manager gets deleted via
ecore_wl2_surface_manager_del
- Now the code continues without any loaded surface manager
- Creating a window will error out in EE
- No window can be created at all
- Every single test fails
Greetings,
bu5hm4n
On 1/20/20 6:16 PM, Christopher Michael wrote:
On 1/20/20 11:53 AM, Marcel Hollerbach wrote:
bu5hm4n pushed a commit to branch master.
[1]http://git.enlightenment.org/core/efl.git/commit/?id=55ec2dc89e9b
38ad52c5e8b3d8ac42c8e906bba6
commit 55ec2dc89e9b38ad52c5e8b3d8ac42c8e906bba6
Author: Marcel Hollerbach[2]<[email protected]>
Date: Mon Jan 20 17:51:40 2020 +0100
Revert "ecore_wl2: Fix a memory leaking case"
This reverts commit
97e71b9dc4fa73da99a890d9c39d6617e529dc94.
This commit is absolutly wrong. This makes running wayland
apps intree
impossible, and also crashes tests when run in wayland mode.
Which tests were crashing with this ?? Were they Ecore_Wl2 tests ?
dh
I asked multiple times in the revision for clarification,
noone
answered.
This tricked me today for the second time, so better revert
that.
---
src/lib/ecore_wl2/ecore_wl2.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/lib/ecore_wl2/ecore_wl2.c
b/src/lib/ecore_wl2/ecore_wl2.c
index d14b14aee5..33e06873cd 100644
--- a/src/lib/ecore_wl2/ecore_wl2.c
+++ b/src/lib/ecore_wl2/ecore_wl2.c
@@ -90,8 +90,6 @@ _ecore_wl2_surface_modules_init(void)
local_module = NULL;
return EINA_FALSE;
}
- eina_module_free(local_module);
- local_module = NULL;
return EINA_TRUE;
}
}
_______________________________________________
enlightenment-devel mailing list
[3][email protected]
[4]https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
References
1.
http://git.enlightenment.org/core/efl.git/commit/?id=55ec2dc89e9b38ad52c5e8b3d8ac42c8e906bba6
2. mailto:[email protected]
3. mailto:[email protected]
4. https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
