On Sun, 23 Aug 2020 21:46:14 -0400 Christopher Michael <[email protected]>
said:
I don't get these... and check.h says they are fine:
#define fail_if(expr, ...)\
(expr) ? \
_ck_assert_failed(__FILE__, __LINE__, "Failure '"#expr"' occurred" , ##
__VA_ARGS__, NULL) \ : _mark_point(__FILE__, __LINE__)
CK_DLL_EXP void CK_EXPORT _ck_assert_failed(const char *file, int line,
const char *expr,
...) CK_ATTRIBUTE_NORETURN
CK_ATTRIBUTE_FORMAT(gnu_printf, 3, 4);
so efl_class_new(NULL, (Efl_Class *) buf) falls under expr and the rest
is ... NULL is a "end of args" terminator as u can see in the macro...
i suspect your check is different.incompatible with the check version i have. i
have heard of late a new check version broke a lot of stuff. i don't think the
test code is at fault here and its something else check related.
> Please read The "-------------------" lines.....
>
>
> ------------------- REALLY ??? What the..@#&*F!^%.... is this stuff...?
>
>
> [2275/3825] Compiling C object
> src/tests/eo/suite/eo_suite.p/eo_test_general.c.o
> ../src/tests/eo/suite/eo_test_general.c: In function ‘eo_magic_checks_fn’:
> ../src/tests/eo/suite/eo_test_general.c:994:9: warning: too many
> arguments for format [-Wformat-extra-args]
> 994 | fail_if(efl_class_new(NULL, (Efl_Class *) buf), NULL);
> | ^~~~~~~
>
>
> [2297/3825] Compiling C object
> src/tests/eo/suite/eo_suite_dbg.p/eo_test_general.c.o
> ../src/tests/eo/suite/eo_test_general.c: In function ‘eo_magic_checks_fn’:
> ../src/tests/eo/suite/eo_test_general.c:994:9: warning: too many
> arguments for format [-Wformat-extra-args]
> 994 | fail_if(efl_class_new(NULL, (Efl_Class *) buf), NULL);
> | ^~~~~~~
> [2298/3825] Compiling C object
> src/tests/eo/signals/eo_signals_dbg.p/signals_main.c.o
>
>
> [2317/3825] Compiling C object
> src/tests/eo/suite/eo_suite_fallback.p/eo_test_general.c.o
> ../src/tests/eo/suite/eo_test_general.c: In function ‘eo_magic_checks_fn’:
> ../src/tests/eo/suite/eo_test_general.c:994:9: warning: too many
> arguments for format [-Wformat-extra-args]
> 994 | fail_if(efl_class_new(NULL, (Efl_Class *) buf), NULL);
> | ^~~~~~~
> [2318/3825] Compiling C object
> src/tests/eo/mixin/eo_mixin_dbg.p/mixin_mixin2.c.o
>
>
> [2410/3825] Compiling C object
> src/tests/ecore/ecore_suite.p/ecore_test_timer.c.o
> In file included from ../src/tests/ecore/ecore_suite.h:4,
> from ../src/tests/ecore/ecore_test_timer.c:9:
> ../src/tests/ecore/ecore_test_timer.c: In function ‘_timer2_cb’:
> ../src/tests/ecore/ecore_test_timer.c:56:35: warning: too many arguments
> for format [-Wformat-extra-args]
> 56 | fail_if(timer->add_timer2 > 1, "Error add/delay timer");
> | ^~~~~~~~~~~~~~~~~~~~~~~
> ../src/tests/ecore/ecore_test_timer.c:63:103: warning: too many
> arguments for format [-Wformat-extra-args]
> 63 | fail_if(!EINA_DBL_EQ(timer->interval_1[timer->num_elem],
> ecore_timer_interval_get(timer->timer1)), "Error set new interval");
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> ../src/tests/ecore/ecore_test_timer.c:67:90: warning: too many arguments
> for format [-Wformat-extra-args]
> 67 | fail_if(!EINA_DBL_EQ(timer->precision[timer->num_elem],
> ecore_timer_precision_get()), "Error set new precision");
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> ../src/tests/ecore/ecore_test_timer.c: In function ‘_timer4_cb’:
> ../src/tests/ecore/ecore_test_timer.c:103:71: warning: too many
> arguments for format [-Wformat-extra-args]
> 103 | fail_if(timer->check_freeze_thaw_timer3 !=
> timer->count_timer3, "Error frezze/thaw timer");
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> ../src/tests/ecore/ecore_test_timer.c: In function ‘ecore_test_timers_fn’:
> ../src/tests/ecore/ecore_test_timer.c:156:97: warning: too many
> arguments for format [-Wformat-extra-args]
> 156 | fail_if((!timer.timer1 || !timer.timer2 || !timer.timer3 ||
> !timer.timer4 || !timer.timer5), "Error add timer\n");
> | ^~~~~~~~~~~~~~~~~~~
> ../src/tests/ecore/ecore_test_timer.c: In function
> ‘ecore_test_timer_inside_call_fn’:
> ../src/tests/ecore/ecore_test_timer.c:210:19: warning: too many
> arguments for format [-Wformat-extra-args]
> 210 | fail_if(!c->t, "Error add timer\n");
> | ^~~~~~~~~~~~~~~~~~~
> ../src/tests/ecore/ecore_test_timer.c: In function
> ‘ecore_test_timer_valid_callbackfunc_fn’:
> ../src/tests/ecore/ecore_test_timer.c:220:52: warning: too many
> arguments for format [-Wformat-extra-args]
> 220 | fail_if((t = ecore_timer_add(0.5, NULL, NULL)), "ERROR:
> Invalid callback func!\n");
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../src/tests/ecore/ecore_test_timer.c: In function ‘_timer_cb’:
> ../src/tests/ecore/ecore_test_timer.c:262:27: warning: too many
> arguments for format [-Wformat-extra-args]
> 262 | fail_if (num != count, "Error timer is called out of order");
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> [2411/3825] Compiling C object
> src/tests/ecore/ecore_suite.p/ecore_test_ecore.c.o
> [2412/3825] Compiling C object
> src/tests/ecore/ecore_suite.p/ecore_test_animator.c.o
>
> -------------------Damn, Still not figured out "format"....
>
> [2447/3825] Compiling C object
> src/tests/ecore_con/ecore_con_suite.p/ecore_con_test_efl_net_ip_address.c.o
> ../src/tests/ecore_con/ecore_con_test_efl_net_ip_address.c: In function
> ‘_assert_found_internal’:
> ../src/tests/ecore_con/ecore_con_test_efl_net_ip_address.c:177:24:
> warning: too many arguments for format [-Wformat-extra-args]
> 177 | "Expected error=%d (%s), got %d (%s)
> resolving=%s",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../src/tests/ecore_con/ecore_con_test_efl_net_ip_address.c:195:22:
> warning: too many arguments for format [-Wformat-extra-args]
> 195 | "Expected found=%hhu, got %hhu resolving=%s",
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> [2448/3825] Compiling C object
> src/tests/ecore_wl2/ecore_wl2_suite.p/ecore_wl2_test_output.c.o
> [2449/3825] Compiling C object
> src/tests/ecore_wl2/ecore_wl2_suite.p/ecore_wl2_test_input.c.o
> [2450/3825] Compiling C object
> src/tests/elput/elput_suite.p/elput_test_elput.c.o
> [2451/3825] Compiling C object
> src/tests/ecore/efl_app_suite.p/efl_app_test_promise.c.o
> [2452/3825] Compiling C object
> src/tests/evas/evas_suite.p/evas_test_render_engines.c.o
> In file included from ../src/tests/evas/evas_suite.h:4,
> from ../src/tests/evas/evas_test_render_engines.c:10:
> ../src/tests/evas/evas_test_render_engines.c: In function
> ‘evas_render_engines_fn’:
> ../src/tests/evas/evas_test_render_engines.c:61:25: warning: too many
> arguments for format [-Wformat-extra-args]
> 61 | fail_if(!found, "module should be built, but was not
> found: %s", *itr);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../src/tests/evas/evas_test_render_engines.c: In function
> ‘evas_render_lookup_fn’:
> ../src/tests/evas/evas_test_render_engines.c:75:26: warning: too many
> arguments for format [-Wformat-extra-args]
> 75 | fail_if(id == 0, "could not load engine: %s", *itr);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>
>
> [2490/3825] Compiling C object
> src/tests/evas/evas_suite.p/evas_test_image.c.o
> In file included from ../src/tests/evas/evas_suite.h:4,
> from ../src/tests/evas/evas_test_image.c:14:
> ../src/tests/evas/evas_test_image.c: In function
> ‘evas_object_image_loader_orientation_fn’:
> ../src/tests/evas/evas_test_image.c:281:17: warning: too many arguments
> for format [-Wformat-extra-args]
> 281 | "Image orientation test failed: exif
> orientation flag: %s\n", res[i].desc);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../src/tests/evas/evas_test_image.c: In function
> ‘evas_object_image_orient_fn’:
> ../src/tests/evas/evas_test_image.c:331:17: warning: too many arguments
> for format [-Wformat-extra-args]
> 331 | "Image orientation test failed: orient flag:
> %s\n", res[i].desc);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../src/tests/evas/evas_test_image.c: In function
> ‘evas_object_image_partially_load_orientation_fn’:
> ../src/tests/evas/evas_test_image.c:621:17: warning: too many arguments
> for format [-Wformat-extra-args]
> 621 | "Image orientation partially load test failed:
> exif orientation flag: %s\n", res[i].desc);
> |
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../src/tests/evas/evas_test_image.c: In function
> ‘evas_object_image_map_unmap_fn’:
> ../src/tests/evas/evas_test_image.c:941:66: warning: too many arguments
> for format [-Wformat-extra-args]
> 941 | fail_if(orig[y*stride/4 + x] !=
> dest[y*stride2/4+x], "pixels differ [1]");
> | ^~~~~~~~~~~~~~~~~~~
> ../src/tests/evas/evas_test_image.c:949:51: warning: too many arguments
> for format [-Wformat-extra-args]
> 949 | fail_if(dest[y*stride/4 + x] != c, "pixels
> differ [2]");
> | ^~~~~~~~~~~~~~~~~~~
> ../src/tests/evas/evas_test_image.c:958:51: warning: too many arguments
> for format [-Wformat-extra-args]
> 958 | fail_if(dest[y*stride/4 + x] != c, "pixels
> differ [2bis]");
> | ^~~~~~~~~~~~~~~~~~~~~~
> ../src/tests/evas/evas_test_image.c:965:58: warning: too many arguments
> for format [-Wformat-extra-args]
> 965 | fail_if(dest[y*stride/4 + x] != 0xFF00FF00,
> "pixels differ [3]");
> | ^~~~~~~~~~~~~~~~~~~
> ../src/tests/evas/evas_test_image.c:966:62: warning: too many arguments
> for format [-Wformat-extra-args]
> 966 | fail_if(dest[(y+1)*stride/4 + x] != 0xFFFF0000,
> "pixels differ [4]");
> | ^~~~~~~~~~~~~~~~~~~
> [2491/3825] Linking target src/tests/efreet/efreet_suite
>
>
> -------------------Well BALLS ... still making the same mistake.....
>
>
> [2524/3825] Compiling C object
> src/tests/eio/eio_suite.p/efl_io_model_test_monitor_add.c.o
> In file included from ../src/tests/eio/eio_suite.h:4,
> from ../src/tests/eio/efl_io_model_test_monitor_add.c:13:
> ../src/tests/eio/efl_io_model_test_monitor_add.c: In function
> ‘efl_io_model_test_test_monitor_add_fn’:
> ../src/tests/eio/efl_io_model_test_monitor_add.c:175:24: warning: too
> many arguments for format [-Wformat-extra-args]
> 175 | fail_if(!filemodel, "ERROR: Cannot init model!\n");
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> [2525/3825] Compiling C object src/tests/eio/eio_suite.p/eio_test_file.c.o
>
>
>
> ------------------- SHOULD I KEEP GOING ??????
>
> What kind of commits are these that don't compile clean ? How did this
> stuff even pass ?
>
>
>
> [2490/3825] Compiling C object
> src/tests/evas/evas_suite.p/evas_test_image.c.o
> In file included from ../src/tests/evas/evas_suite.h:4,
> from ../src/tests/evas/evas_test_image.c:14:
> ../src/tests/evas/evas_test_image.c: In function
> ‘evas_object_image_loader_orientation_fn’:
> ../src/tests/evas/evas_test_image.c:281:17: warning: too many arguments
> for format [-Wformat-extra-args]
> 281 | "Image orientation test failed: exif
> orientation flag: %s\n", res[i].desc);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../src/tests/evas/evas_test_image.c: In function
> ‘evas_object_image_orient_fn’:
> ../src/tests/evas/evas_test_image.c:331:17: warning: too many arguments
> for format [-Wformat-extra-args]
> 331 | "Image orientation test failed: orient flag:
> %s\n", res[i].desc);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../src/tests/evas/evas_test_image.c: In function
> ‘evas_object_image_partially_load_orientation_fn’:
> ../src/tests/evas/evas_test_image.c:621:17: warning: too many arguments
> for format [-Wformat-extra-args]
> 621 | "Image orientation partially load test failed:
> exif orientation flag: %s\n", res[i].desc);
> |
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../src/tests/evas/evas_test_image.c: In function
> ‘evas_object_image_map_unmap_fn’:
> ../src/tests/evas/evas_test_image.c:941:66: warning: too many arguments
> for format [-Wformat-extra-args]
> 941 | fail_if(orig[y*stride/4 + x] !=
> dest[y*stride2/4+x], "pixels differ [1]");
> | ^~~~~~~~~~~~~~~~~~~
> ../src/tests/evas/evas_test_image.c:949:51: warning: too many arguments
> for format [-Wformat-extra-args]
> 949 | fail_if(dest[y*stride/4 + x] != c, "pixels
> differ [2]");
> | ^~~~~~~~~~~~~~~~~~~
> ../src/tests/evas/evas_test_image.c:958:51: warning: too many arguments
> for format [-Wformat-extra-args]
> 958 | fail_if(dest[y*stride/4 + x] != c, "pixels
> differ [2bis]");
> | ^~~~~~~~~~~~~~~~~~~~~~
> ../src/tests/evas/evas_test_image.c:965:58: warning: too many arguments
> for format [-Wformat-extra-args]
> 965 | fail_if(dest[y*stride/4 + x] != 0xFF00FF00,
> "pixels differ [3]");
> | ^~~~~~~~~~~~~~~~~~~
> ../src/tests/evas/evas_test_image.c:966:62: warning: too many arguments
> for format [-Wformat-extra-args]
> 966 | fail_if(dest[(y+1)*stride/4 + x] != 0xFFFF0000,
> "pixels differ [4]");
> | ^~~~~~~~~~~~~~~~~~~
> [2491/3825] Linking target src/tests/efreet/efreet_suite
>
>
> [2524/3825] Compiling C object
> src/tests/eio/eio_suite.p/efl_io_model_test_monitor_add.c.o
> In file included from ../src/tests/eio/eio_suite.h:4,
> from ../src/tests/eio/efl_io_model_test_monitor_add.c:13:
> ../src/tests/eio/efl_io_model_test_monitor_add.c: In function
> ‘efl_io_model_test_test_monitor_add_fn’:
> ../src/tests/eio/efl_io_model_test_monitor_add.c:175:24: warning: too
> many arguments for format [-Wformat-extra-args]
> 175 | fail_if(!filemodel, "ERROR: Cannot init model!\n");
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> [2525/3825] Compiling C object src/tests/eio/eio_suite.p/eio_test_file.c.o
>
>
> [2534/3825] Compiling C object
> src/tests/eio/eio_suite.p/efl_io_model_test_file.c.o
> In file included from ../src/tests/eio/eio_suite.h:4,
> from ../src/tests/eio/efl_io_model_test_file.c:13:
> ../src/tests/eio/efl_io_model_test_file.c: In function
> ‘efl_io_model_test_test_file_fn’:
> ../src/tests/eio/efl_io_model_test_file.c:171:24: warning: too many
> arguments for format [-Wformat-extra-args]
> 171 | fail_if(!filemodel, "ERROR: Cannot init model!\n");
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> [2535/3825] Generating eolian_gen_focus_manager_test.eo with a custom
> command
>
>
>
> ------------------- WOW, It's like we forgot how to spell or something....
>
> Can't use "format" apparently.,....AAARRRRGGGGSSSS....
>
>
> dh
>
>
>
> On 8/23/20 8:50 PM, Christopher Michael wrote:
> > How can Test Code like this pass when a string can't be formatted ??
> > Too many args ?
> >
> > How was this pushed with this many warnings ??
> >
> >
> > dh
> >
> >
> > See the help page for details.
> > [346/3825] Compiling C object
> > src/tests/eina/eina_suite.p/eina_test_value.c.o
> > In file included from ../src/tests/eina/eina_suite.h:22,
> > from ../src/tests/eina/eina_test_value.c:29:
> > ../src/tests/eina/eina_test_value.c: In function
> > ‘eina_value_test_hash_fn’:
> > ../src/tests/eina/eina_test_value.c:2348:42: warning: too many
> > arguments for format [-Wformat-extra-args]
> > 2348 | fail_unless(strstr(str, buf) != NULL, "Couldn't find '%s'
> > in '%s'", buf, str);
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > ../src/tests/eina/eina_test_value.c:2351:42: warning: too many
> > arguments for format [-Wformat-extra-args]
> > 2351 | fail_unless(strstr(str, buf) != NULL, "Couldn't find '%s'
> > in '%s'", buf, str);
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > ../src/tests/eina/eina_test_value.c:2354:42: warning: too many
> > arguments for format [-Wformat-extra-args]
> > 2354 | fail_unless(strstr(str, buf) != NULL, "Couldn't find '%s'
> > in '%s'", buf, str);
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > ../src/tests/eina/eina_test_value.c:2371:42: warning: too many
> > arguments for format [-Wformat-extra-args]
> > 2371 | fail_unless(strstr(str, buf) != NULL, "Couldn't find '%s'
> > in '%s'", buf, str);
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > ../src/tests/eina/eina_test_value.c:2374:42: warning: too many
> > arguments for format [-Wformat-extra-args]
> > 2374 | fail_unless(strstr(str, buf) != NULL, "Couldn't find '%s'
> > in '%s'", buf, str);
> > |
> >
> >
>
>
> _______________________________________________
> enlightenment-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
------------- Codito, ergo sum - "I code, therefore I am" --------------
Carsten Haitzler - [email protected]
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
