Again ...
Doesn't anyone check returns ? Why have a function that Gives a Return
but not use it ?
Simple but missed...
Thanks Old Man for doing Coverity stuffs ...
dh
On 9/19/20 7:23 PM, Carsten Haitzler wrote:
raster pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=52b02055f45ccb32b55b39bb5b518403c55c86b6
commit 52b02055f45ccb32b55b39bb5b518403c55c86b6
Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com>
Date: Sun Sep 20 00:06:30 2020 +0100
ecore - efl thread - dont close invalid < 0 fd's
fix CID 1396951
---
src/lib/ecore/efl_thread.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/lib/ecore/efl_thread.c b/src/lib/ecore/efl_thread.c
index ab6fdab7a1..9fc6b8d882 100644
--- a/src/lib/ecore/efl_thread.c
+++ b/src/lib/ecore/efl_thread.c
@@ -826,8 +826,8 @@ _efl_thread_efl_task_run(Eo *obj, Efl_Thread_Data *pd)
close(pd->fd.out);
close(pd->ctrl.in);
close(pd->ctrl.out);
- close(thdat->fd.in);
- close(thdat->fd.out);
+ if (thdat->fd.in >= 0) close(thdat->fd.in);
+ if (thdat->fd.out >= 0) close(thdat->fd.out);
close(thdat->ctrl.in);
close(thdat->ctrl.out);
free(thdat);
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
