This is an automated email from the git hooks/post-receive script.
git pushed a commit to branch master
in repository e16.
View the commit online.
commit 6369dfa7ddac282310fce83505212d8c9cf8f0e8
Author: Kim Woelders <[email protected]>
AuthorDate: Sat Jul 2 19:11:36 2022 +0200
menus: Fix potential crash
When requesting to show a menu already shown it would be hidden before
being shown again, which could cause a crash due to incorrect processing
of reparent events.
Now we just ignore requests to show a menu that is aleady shown, which
bypasses the event processing issue and is reasonable anyway.
---
src/menus.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/menus.c b/src/menus.c
index 1695238e..669e3043 100644
--- a/src/menus.c
+++ b/src/menus.c
@@ -1150,13 +1150,16 @@ MenusShowNamed(const char *name, const char *param)
if (name2)
name = name2;
+ m = MenuFind(name, param);
+ if (m && m->shown)
+ return; /* Quit if already shown */
+
/* Hide any menus currently up */
if (MenusActive())
MenusHide();
- m = MenuFind(name, param);
if (!m)
- return;
+ return; /* Quit if menu not found */
if (!m->ewin) /* Don't show if already shown */
MenuShow(m, 0);
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
