This is an automated email from the git hooks/post-receive script.
git pushed a commit to branch master
in repository efm2.
View the commit online.
commit 11fa91ca7373fe6b282d64e88dfd053f1287bb93
Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com>
AuthorDate: Tue Jun 27 14:07:49 2023 +0100
clean up comments, formatting and todo
---
TODO.md | 3 +++
src/efm/efm.h | 28 ++++++++++++----------------
src/efm/efm_dnd.c | 2 +-
src/efm/efm_util.c | 4 ----
4 files changed, 16 insertions(+), 21 deletions(-)
diff --git a/TODO.md b/TODO.md
index c35aa41..80aa20a 100644
--- a/TODO.md
+++ b/TODO.md
@@ -52,6 +52,9 @@
* Open file with mime handler
* Open with ...
* File actions (separate to open with...)
+* Set/get column sizes
+* Callbacks when column sizes change
+* Set/get icon size
## Medium term
diff --git a/src/efm/efm.h b/src/efm/efm.h
index 39ee29f..13d4e6b 100644
--- a/src/efm/efm.h
+++ b/src/efm/efm.h
@@ -39,28 +39,24 @@ typedef enum {
EFM_FOCUS_DIR_PGUP
} Efm_Focus_Dir;
-Evas_Object *efm_add(Evas_Object *parent);
-void efm_scroller_set(Evas_Object *obj, Evas_Object *scroller);
-Evas_Object *efm_scroller_get(Evas_Object *obj);
-Evas_Object *efm_detail_header_get(Evas_Object *obj);
-void efm_path_set(Evas_Object *obj, const char *path);
-const char *efm_path_get(Evas_Object *obj);
+Evas_Object *efm_add (Evas_Object *parent);
+void efm_scroller_set (Evas_Object *obj, Evas_Object *scroller);
+Evas_Object *efm_scroller_get (Evas_Object *obj);
+Evas_Object *efm_detail_header_get (Evas_Object *obj);
+void efm_path_set (Evas_Object *obj, const char *path);
+const char *efm_path_get (Evas_Object *obj);
void efm_path_view_mode_set(Evas_Object *obj, Efm_View_Mode mode);
Efm_View_Mode efm_path_view_mode_get(Evas_Object *obj);
void efm_path_sort_mode_set(Evas_Object *obj, Efm_Sort_Mode mode);
Efm_Sort_Mode efm_path_sort_mode_get(Evas_Object *obj);
-Evas_Coord efm_column_min_get(Evas_Object *obj, int col);
+Evas_Coord efm_column_min_get (Evas_Object *obj, int col);
-// XXX: set/get column sizes
-// XXX: callback when column sizes change
-// XXX: set/get icon size
-// XXX: hidden files show set/get
+#define DBG(...) EINA_LOG_DOM_DBG (_log_dom, __VA_ARGS__)
+#define INF(...) EINA_LOG_DOM_INFO(_log_dom, __VA_ARGS__)
+#define WRN(...) EINA_LOG_DOM_WARN(_log_dom, __VA_ARGS__)
+#define ERR(...) EINA_LOG_DOM_ERR (_log_dom, __VA_ARGS__)
+#define CRI(...) EINA_LOG_DOM_CRIT(_log_dom, __VA_ARGS__)
-#define DBG(...) EINA_LOG_DOM_DBG(_log_dom, __VA_ARGS__)
-#define INF(...) EINA_LOG_DOM_INFO(_log_dom, __VA_ARGS__)
-#define WRN(...) EINA_LOG_DOM_WARN(_log_dom, __VA_ARGS__)
-#define ERR(...) EINA_LOG_DOM_ERR(_log_dom, __VA_ARGS__)
-#define CRI(...) EINA_LOG_DOM_CRIT(_log_dom, __VA_ARGS__)
extern int _log_dom;
#endif
diff --git a/src/efm/efm_dnd.c b/src/efm/efm_dnd.c
index b45d925..18f343d 100644
--- a/src/efm/efm_dnd.c
+++ b/src/efm/efm_dnd.c
@@ -176,7 +176,7 @@ _cb_drag_icon_add(void *data, Evas_Object *parent, Evas_Coord *xoff, Evas_Coord
int num = 0;
if (sd->config.view_mode >= EFM_VIEW_MODE_LIST)
- {
+ { // figure out number so we know odd/even mode for list items
EINA_LIST_FOREACH(sd->blocks, bl, block)
{
if (block->realized_num <= 0)
diff --git a/src/efm/efm_util.c b/src/efm/efm_util.c
index 5108e53..a41dfec 100644
--- a/src/efm/efm_util.c
+++ b/src/efm/efm_util.c
@@ -868,7 +868,6 @@ _cb_icon_mouse_up(void *data, Evas *e EINA_UNUSED, Evas_Object *obj EINA_UNUSED,
if (ev->event_flags & EVAS_EVENT_FLAG_ON_HOLD) goto done;
if ((ev->button == 1) && (icon->down))
{ // click + release
- // XXX: kill longpress timer
dx = ev->canvas.x - icon->down_x;
dy = ev->canvas.y - icon->down_y;
if (((dx * dx) + (dy * dy)) > (5 * 5)) dragged = EINA_TRUE;
@@ -1198,9 +1197,6 @@ _icon_object_add(Icon *icon, Smart_Data *sd, Evas *e, const char *theme_edj_file
tmps = eina_strftime("%H:%M:%S", info);
edje_object_part_text_set(o2, "e.text.time", tmps);
free(tmps);
-// tmps = eina_strftime("%b %d %y %H:%M:%S", info);
-// edje_object_part_text_set(icon->o_base, "e.text.detail2", tmps);
-// free(tmps);
}
s = icon->info.mime;
if (!s) s = "";
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
