[EGIT] [efl] 01/01: elm - win - fix xsd icon hint set with junk stack data and crash

[Enlightenment Git]

This is an automated email from the git hooks/post-receive script.

git pushed a commit to branch master
in repository efl.

View the commit online.

commit 35bc3f933fe10290fe1a2b4d640f9210fdf8f976
Author: Carsten Haitzler <ras...@rasterman.com>
AuthorDate: Fri Feb 9 18:36:52 2024 +0000

    elm - win - fix xsd icon hint set with junk stack data and crash
    
    fixes a crash accessing junk on stack data that was unset for netwm
    icon hints.
    
    @fix
---
 src/lib/elementary/efl_ui_win.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/lib/elementary/efl_ui_win.c b/src/lib/elementary/efl_ui_win.c
index 5ce1967f30..067791e259 100644
--- a/src/lib/elementary/efl_ui_win.c
+++ b/src/lib/elementary/efl_ui_win.c
@@ -3563,13 +3563,13 @@ _elm_win_xwin_update(Efl_Ui_Win_Data *sd)
 
         if (image)
           {
-             int w = 0, h = 0, stride, x, y;
+             int w = 0, h = 0, stride = 0, x, y;
              Eina_Bool unmap = EINA_FALSE;
-             Eina_Rw_Slice sl = {};
+             Eina_Rw_Slice sl = { 0 };
 
              if (efl_isa(image, EFL_CANVAS_IMAGE_CLASS))
                {
-                  Eina_Rect rect = {};
+                  Eina_Rect rect = { 0 };
 
                   unmap = EINA_TRUE;
                   rect.size = efl_gfx_buffer_size_get(image);
@@ -3578,12 +3578,14 @@ _elm_win_xwin_update(Efl_Ui_Win_Data *sd)
                                           &stride);
                   w = rect.w;
                   h = rect.h;
+//                 printf("a %ix%i %p\n", w, h, sl.mem);
                }
              else
                {
                   evas_object_image_size_get(image, &w, &h);
                   stride = evas_object_image_stride_get(image);
                   sl.mem = evas_object_image_data_get(image, EINA_FALSE);
+//                 printf("b %ix%i %p\n", w, h, sl.mem);
                }
 
              if (sl.mem)


-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.