On Mon, 11 Sep 2006 19:55:28 +0200 Tilman Sauerbeck <[EMAIL PROTECTED]> babbled:
> Hi, > this is about the FIXME in evas_engine_xrender.c:493. > > If the depth of the surface is 1, we're passing a scaled variant of the > identity matrix to the picture. > > All scaled variants of the identity should be treated the same in the > render implementation, but apparently they aren't. THE BASTARDS! :-P~ (thus the fixme) :) > I just fixed xorg-server so that setting a scaled variant of the > identity is a no-op, too. That means if you pass the identity to > XRenderSetPictureTransform(), the function will just exit and not use > any transform at all. even if it set the identity - i would expect the xserver-side to go "ooh look- identity transform! ... NOP!" :) > This might expose a in the render implementation raster experienced the > source-depth == 1 bug in. > > I'd like to remove the FIXME and that chunk of code, since it's > officially pointless. Should we really work around stupid driver bugs? > It also won't work in xorg 7.2+ :D if this actually has a chance of being fixed in xorg soon - yes - remove... ONCE that xorg is out and about with the fixes :) so... if it goes into xorg git - then change the fixme to "added to xorg git some/date/2006 - expected in release 7.x" and once we encounter that release in the wild - flip over... or make it a #ifdef broken_xrender too :) > May I remove that chunk or do you want to keep it? Patch attached. > > Regards, > Tilman > > -- > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the most annoying thing on usenet and in e-mail? > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [EMAIL PROTECTED] 裸好多 Tokyo, Japan (東京 日本) ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
