This is an automated email from the git hooks/post-receive script.

git pushed a commit to branch v-0.27
in repository enlightenment.

View the commit online.

commit 716b5274da66a1f75672a5895c38d71c4c4e6ff5
Author: Carsten Haitzler <ras...@rasterman.com>
AuthorDate: Thu Feb 13 10:29:19 2025 +0000

    app menu - fix - even better dont show menu items with no desktop
    
    don't even offer options if there is no desktop file to do anything
    with in other app submenu items
    
    @fix
---
 src/bin/e_int_client_menu.c | 40 +++++++++++++++++++++-------------------
 1 file changed, 21 insertions(+), 19 deletions(-)

diff --git a/src/bin/e_int_client_menu.c b/src/bin/e_int_client_menu.c
index 568e3cfcd..442e85458 100644
--- a/src/bin/e_int_client_menu.c
+++ b/src/bin/e_int_client_menu.c
@@ -688,28 +688,30 @@ _e_client_menu_cb_application_pre(void *data, E_Menu *m EINA_UNUSED, E_Menu_Item
         e_menu_item_callback_set(submi, _e_client_menu_cb_icon_edit, ec);
      }
 
-   submi = e_menu_item_new(subm);
-   e_menu_item_separator_set(submi, 1);
+   if (ec->desktop)
+    {
+      submi = e_menu_item_new(subm);
+      e_menu_item_separator_set(submi, 1);
 
-   submi = e_menu_item_new(subm);
-   e_menu_item_label_set(submi, _("Add to Favorites Menu"));
-   e_menu_item_callback_set(submi, _e_client_menu_cb_fav_add, ec);
-   e_util_menu_item_theme_icon_set(submi, "user-bookmarks");
+      submi = e_menu_item_new(subm);
+      e_menu_item_label_set(submi, _("Add to Favorites Menu"));
+      e_menu_item_callback_set(submi, _e_client_menu_cb_fav_add, ec);
+      e_util_menu_item_theme_icon_set(submi, "user-bookmarks");
 
-   submi = e_menu_item_new(subm);
-   e_menu_item_label_set(submi, _("Add to IBar"));
-   e_menu_item_submenu_pre_callback_set(submi,
-                                        _e_client_menu_cb_ibar_add_pre, ec);
-   e_util_menu_item_theme_icon_set(submi, "preferences-applications-ibar");
+      submi = e_menu_item_new(subm);
+      e_menu_item_label_set(submi, _("Add to IBar"));
+      e_menu_item_submenu_pre_callback_set(submi,
+                                           _e_client_menu_cb_ibar_add_pre, ec);
+      e_util_menu_item_theme_icon_set(submi, "preferences-applications-ibar");
 
-   if (e_configure_registry_exists("keyboard_and_mouse/key_bindings") &&
-       (ec->desktop))
-     {
-        submi = e_menu_item_new(subm);
-        e_menu_item_label_set(submi, _("Create Keyboard Shortcut"));
-        e_menu_item_callback_set(submi, _e_client_menu_cb_kbdshrtct_add, ec);
-        e_util_menu_item_theme_icon_set(submi, "preferences-desktop-keyboard");
-     }
+      if (e_configure_registry_exists("keyboard_and_mouse/key_bindings"))
+        {
+          submi = e_menu_item_new(subm);
+          e_menu_item_label_set(submi, _("Create Keyboard Shortcut"));
+          e_menu_item_callback_set(submi, _e_client_menu_cb_kbdshrtct_add, ec);
+          e_util_menu_item_theme_icon_set(submi, "preferences-desktop-keyboard");
+        }
+    }
 #if 0
    if (ec->color_editor || (!e_pixmap_is_x(ec->pixmap))) return;
    submi = e_menu_item_new(subm);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.

Reply via email to