This is an automated email from the git hooks/post-receive script.
git pushed a commit to branch devs/devilhorns/apos
in repository efl.
View the commit online.
commit 12b790aa6013fd336c2e2a07e02466b0eb1e7189
Author: Christopher Michael <devilho...@comcast.net>
AuthorDate: Tue Nov 8 07:49:34 2022 -0500
ecore_drm2: Fix invalid free, remove useless goto, and don't create
more than one eina_thread_queue
---
src/lib/ecore_drm2/ecore_drm2_crtcs.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/lib/ecore_drm2/ecore_drm2_crtcs.c b/src/lib/ecore_drm2/ecore_drm2_crtcs.c
index 3472ddccf3..5743373245 100644
--- a/src/lib/ecore_drm2/ecore_drm2_crtcs.c
+++ b/src/lib/ecore_drm2/ecore_drm2_crtcs.c
@@ -181,7 +181,7 @@ _ecore_drm2_crtc_create(Ecore_Drm2_Device *dev, drmModeCrtcPtr dcrtc, uint32_t p
if (!crtc)
{
ERR("Could not allocate space for CRTC");
- goto err;
+ return NULL;
}
crtc->id = dcrtc->crtc_id;
@@ -193,10 +193,6 @@ _ecore_drm2_crtc_create(Ecore_Drm2_Device *dev, drmModeCrtcPtr dcrtc, uint32_t p
dev->crtcs = eina_list_append(dev->crtcs, crtc);
return crtc;
-
-err:
- free(crtc);
- return NULL;
}
Eina_Bool
@@ -211,6 +207,8 @@ _ecore_drm2_crtcs_create(Ecore_Drm2_Device *dev)
res = sym_drmModeGetResources(dev->fd);
if (!res) return EINA_FALSE;
+ thq = eina_thread_queue_new();
+
for (; i < res->count_crtcs; i++)
{
/* try to get this crtc from drm */
@@ -221,7 +219,6 @@ _ecore_drm2_crtcs_create(Ecore_Drm2_Device *dev)
if (!crtc) goto err;
/* NB: Use an explicit thread to fill crtc atomic state */
- thq = eina_thread_queue_new();
crtc->thread =
ecore_thread_feedback_run(_ecore_drm2_crtc_state_thread,
_ecore_drm2_crtc_state_thread_notify,
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
