This is an automated email from the git hooks/post-receive script.

git pushed a commit to branch devs/devilhorns/apos
in repository efl.

View the commit online.

commit 8a6e7eafab02a8af6cc13763c91ceb67ebe02f70
Author: Christopher Michael <devilho...@comcast.net>
AuthorDate: Wed Mar 8 10:29:56 2023 -0500

    ecore_drm2: Change display_rotation_set to not return a value
    
    As the actual changing of this property will now be 'atomic', we
    cannot return a value here until After we try to apply the change so
    remove the return type from the function
---
 src/lib/ecore_drm2/Ecore_Drm2.h          | 2 +-
 src/lib/ecore_drm2/ecore_drm2_displays.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/lib/ecore_drm2/Ecore_Drm2.h b/src/lib/ecore_drm2/Ecore_Drm2.h
index 347e77000b..f07c2dc967 100644
--- a/src/lib/ecore_drm2/Ecore_Drm2.h
+++ b/src/lib/ecore_drm2/Ecore_Drm2.h
@@ -76,7 +76,7 @@ EAPI void ecore_drm2_display_primary_set(Ecore_Drm2_Display *disp, Eina_Bool pri
 EAPI const Eina_List *ecore_drm2_displays_get(Ecore_Drm2_Device *dev);
 EAPI void ecore_drm2_display_info_get(Ecore_Drm2_Display *disp, int *x, int *y, int *w, int *h, unsigned int *refresh);
 EAPI int ecore_drm2_display_rotation_get(Ecore_Drm2_Display *disp);
-EAPI Eina_Bool ecore_drm2_display_rotation_set(Ecore_Drm2_Display *disp, uint64_t rotation);
+EAPI void ecore_drm2_display_rotation_set(Ecore_Drm2_Display *disp, uint64_t rotation);
 
 /* XXX: These are 'test' APIs */
 EAPI void ecore_drm2_display_mode_set(Ecore_Drm2_Display *disp, Ecore_Drm2_Display_Mode *mode, int x, int y);
diff --git a/src/lib/ecore_drm2/ecore_drm2_displays.c b/src/lib/ecore_drm2/ecore_drm2_displays.c
index 0f44feaa14..93e9a03b90 100644
--- a/src/lib/ecore_drm2/ecore_drm2_displays.c
+++ b/src/lib/ecore_drm2/ecore_drm2_displays.c
@@ -810,17 +810,15 @@ ecore_drm2_display_rotation_get(Ecore_Drm2_Display *disp)
    return disp->state.current->rotation;
 }
 
-EAPI Eina_Bool
+EAPI void
 ecore_drm2_display_rotation_set(Ecore_Drm2_Display *disp, uint64_t rotation)
 {
-   EINA_SAFETY_ON_NULL_RETURN_VAL(disp, EINA_FALSE);
+   EINA_SAFETY_ON_NULL_RETURN(disp);
 
-   if (disp->state.current->rotation == rotation) return EINA_TRUE;
+   if (disp->state.current->rotation == rotation) return;
 
    /* TODO, FIXME */
 
    disp->state.pending->rotation = rotation;
    disp->state.pending->changes |= ECORE_DRM2_DISPLAY_STATE_ROTATION;
-
-   return EINA_FALSE;
 }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.

Reply via email to