This is an automated email from the git hooks/post-receive script.
git pushed a commit to branch devs/devilhorns/apos
in repository efl.
View the commit online.
commit 91278f99e10bcd7577a1ec723577818e052b33b0
Author: Christopher Michael <devilho...@comcast.net>
AuthorDate: Mon Aug 4 07:02:52 2025 -0500
ecore_drm2: Fix connectors_changes_apply to be more uniform as with
the other _changes_apply functions
---
src/lib/ecore_drm2/ecore_drm2_connectors.c | 21 +++++++++------------
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/src/lib/ecore_drm2/ecore_drm2_connectors.c b/src/lib/ecore_drm2/ecore_drm2_connectors.c
index 0f7b7d8f4a..3503e1593a 100644
--- a/src/lib/ecore_drm2/ecore_drm2_connectors.c
+++ b/src/lib/ecore_drm2/ecore_drm2_connectors.c
@@ -289,12 +289,9 @@ _ecore_drm2_connectors_changes_apply(Ecore_Drm2_Connector *conn)
pstate->crtc.id,
pstate->crtc.value);
if (ret < 0)
- {
- ERR("Failed to set connector crtc id: %m");
- return EINA_FALSE;
- }
-
- pstate->changes &= ~ECORE_DRM2_CONNECTOR_STATE_CRTC;
+ ERR("Failed to set connector crtc id: %m");
+ else
+ pstate->changes &= ~ECORE_DRM2_CONNECTOR_STATE_CRTC;
}
if (pstate->changes & ECORE_DRM2_CONNECTOR_STATE_DPMS)
@@ -308,12 +305,9 @@ _ecore_drm2_connectors_changes_apply(Ecore_Drm2_Connector *conn)
pstate->dpms.id,
DRM_MODE_DPMS_OFF);
if (ret < 0)
- {
- ERR("Failed to set connector dpms: %m");
- return EINA_FALSE;
- }
-
- pstate->changes &= ~ECORE_DRM2_CONNECTOR_STATE_DPMS;
+ ERR("Failed to set connector dpms: %m");
+ else
+ pstate->changes &= ~ECORE_DRM2_CONNECTOR_STATE_DPMS;
}
if (pstate->changes & ECORE_DRM2_CONNECTOR_STATE_ASPECT)
@@ -332,6 +326,9 @@ _ecore_drm2_connectors_changes_apply(Ecore_Drm2_Connector *conn)
pstate->changes &= ~ECORE_DRM2_CONNECTOR_STATE_SCALING;
}
+ /* if pstate still has some changes listed, than that means something failed */
+ if (pstate->changes) return EINA_FALSE;
+
/* copy pending state to current state on success */
memcpy(cstate, pstate, sizeof(Ecore_Drm2_Connector_State));
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
