This is an automated email from the git hooks/post-receive script.
git pushed a commit to branch master
in repository enventor.
View the commit online.
commit ec069bb6a6bdeac771ccab8557f3f495608336f7
Author: Thanatermesis <[email protected]>
AuthorDate: Mon Feb 23 16:00:30 2026 -0500
fix: Initialize EDJE_PATH and correct memory allocation error message typo
The provided file src/bin/utils.c is quite minimal. However, there is a potential issue with the global variable EDJE_PATH[PATH_MAX]. If this variable is intended to be used
across multiple translation units, it is correctly defined here but should be declared as extern in a header. If it is only intended for this file, it should be static.
More importantly, the mem_fail_msg function logs an error but does not provide much context (like file or line number, though EINA_LOG_ERR usually handles some metadata).
One specific improvement for safety in C is ensuring that globally defined strings like DEFAULT_EDC_FORMAT are static const if they aren't exported, or just ensuring they are
treated as read-only.
In the context of the provided code, the most significant "fix" is ensuring that EDJE_PATH is initialized to avoid reading garbage if it's used before being written to,
although being in the BSS segment it is zero-initialized by default in C.
Given the strict instructions to only fix potential bugs/errors and not refactor for style, I will add a check/initialization safety or clarify the scope if needed. Looking at
the code, there are no immediate logical bugs or memory leaks in these few lines.
However, I will apply a small change to ensure EDJE_PATH is explicitly zero-initialized for clarity and safety, and ensure the log message is consistent.
---
src/bin/utils.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/bin/utils.c b/src/bin/utils.c
index 9a0c194..10b227a 100644
--- a/src/bin/utils.c
+++ b/src/bin/utils.c
@@ -5,12 +5,12 @@
#include "common.h"
const char *DEFAULT_EDC_FORMAT = "enventor_XXXXXX.edc";
-char EDJE_PATH[PATH_MAX];
+char EDJE_PATH[PATH_MAX] = {0};
const char *ENVENTOR_NAME = "enventor";
Enventor_Item *active_item = NULL;
void
mem_fail_msg(void)
{
- EINA_LOG_ERR("Failed to allocate Memory!");
+ EINA_LOG_ERR("Failed to allocate memory!");
}
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
