[EGIT] [evisum] 01/01: visual: we're using a stringshare.

[Enlightenment Git]

This is an automated email from the git hooks/post-receive script.

git pushed a commit to branch master
in repository evisum.

View the commit online.

commit 1d924b19c6fcdaed1b9aa119556f6600ea446bf7
Author: Alastair Poole <alastair.po...@pm.me>
AuthorDate: Sun Mar 29 08:37:30 2026 +0100

    visual: we're using a stringshare.
---
 src/bin/ui/evisum_ui.c | 9 ++++-----
 src/bin/ui/evisum_ui.h | 2 +-
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/bin/ui/evisum_ui.c b/src/bin/ui/evisum_ui.c
index a9be023..2ff53ed 100644
--- a/src/bin/ui/evisum_ui.c
+++ b/src/bin/ui/evisum_ui.c
@@ -63,7 +63,7 @@ evisum_ui_config_save(Evisum_Ui *ui) {
         config()->cpu.x = ui->cpu.x;
         config()->cpu.y = ui->cpu.y;
         config()->cpu.restart = ui->cpu.restart;
-        config()->cpu.visual = ui->cpu.visual;
+        eina_stringshare_replace(&config()->cpu.visual, ui->cpu.visual);
     }
 
     if (ui->mem.win) {
@@ -142,7 +142,7 @@ evisum_ui_config_load(Evisum_Ui *ui) {
     ui->cpu.x = config()->cpu.x;
     ui->cpu.y = config()->cpu.y;
     ui->cpu.restart = config()->cpu.restart;
-    ui->cpu.visual = strdup(config()->cpu.visual);
+    eina_stringshare_replace(&ui->cpu.visual, config()->cpu.visual);
 
     ui->mem.width = config()->mem.width;
     ui->mem.height = config()->mem.height;
@@ -357,8 +357,7 @@ _cpu_visual_clicked_cb(void *data EINA_UNUSED, Evas_Object *obj, void *event_inf
     ui = data;
     txt = elm_object_text_get(obj);
 
-    if (ui->cpu.visual) free(ui->cpu.visual);
-    ui->cpu.visual = strdup(txt);
+    eina_stringshare_replace(&ui->cpu.visual, txt);
     evisum_ui_cpu_win_restart(ui);
 }
 
@@ -708,7 +707,7 @@ evisum_ui_shutdown(Evisum_Ui *ui) {
     ecore_thread_wait(ui->background_poll_thread, 0.5);
     evisum_background_shutdown(ui);
 
-    if (ui->cpu.visual) free(ui->cpu.visual);
+    if (ui->cpu.visual) eina_stringshare_del(ui->cpu.visual);
     free(ui);
 }
 
diff --git a/src/bin/ui/evisum_ui.h b/src/bin/ui/evisum_ui.h
index 5ee6f87..f7d8738 100644
--- a/src/bin/ui/evisum_ui.h
+++ b/src/bin/ui/evisum_ui.h
@@ -61,7 +61,7 @@ typedef struct _Evisum_Ui {
         int height;
         int x, y;
         Eina_Bool restart;
-        char *visual;
+        Eina_Stringshare *visual;
     } cpu;
 
     struct {


-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.